feat: Glorianas via jsons

[CptMacTavish2224]

##Contents

• Glorianas counter in chapter jsons, script to support them as flahships and not doubling with BB
• Apothecaries now no longer start with marked for death, replaced by scholar
• Celestial Lions custom Sergeant name removed cause it bugged the vet sergeants, will address post white scars update
  ##Notes
  DA now actually generate the Invincible Reason as their gloriana and flagship

---

Summary by cubic

Adds Gloriana support to chapter JSONs with automatic flagship spawning. Expands squad generation with bikes/attack bikes, multi-role roles, random equipment, and a cleaner company management view.

• New Features

  • Chapters can set extra_ships.gloriana; the engine creates a Gloriana and uses flagship_name when present. Dark Angels now generate the Invincible Reason.
  • Adds Attack Bike mobility and buffs Bike melee; introduces Bike and Attack Bike squads; includes Lightning Warriors squad presets; equips Dark Angels Black Knights with Power Swords.
  • Supports multi-origin squads via alternative_roles, randomizes equipment loadouts, refactors company panels to sort and summarize roles, and adds an expanded custom chapter template.

• Bug Fixes

  • Prevents double-counting battle barges when a Gloriana exists; flagship assignment prefers the Gloriana.
  • Fixes squad generation edge cases and company view rendering for large chapters; orders squad-specific sergeant variants correctly; corrects Lightning Warriors squad data.
  • Apothecaries now start with scholar instead of marked for death/soft_target; removes Celestial Lions custom sergeant title.
  • Corrects “Monastery” naming and save path; updates Contemptor Dreadnought description.

^{Written for commit 6644200. Summary will update on new commits.}

[cubic-dev-ai]

4 issues found across 26 files

Confidence score: 2/5

• There is a concrete high-impact logic bug in scripts/scr_initialize_custom/scr_initialize_custom.gml: using v=0 instead of v==0 in flagship naming conditions makes both branches unreachable, which can break flagship assignment behavior at runtime.
• Two save-compatibility risks are present: scripts/scr_initialize_custom/scr_initialize_custom.gml reads extra_ships.gloriana without a field-existence fallback, and scripts/scr_chapter_new/scr_chapter_new.gml introduces extra_ships.glorianas without a clear nested-struct migration path for older saves.
• Because these issues are user-facing (game state/load behavior and flagship setup) and reported with relatively high confidence, this sits in high-risk territory until fixes or migration guards are added.
• Pay close attention to scripts/scr_initialize_custom/scr_initialize_custom.gml and scripts/scr_chapter_new/scr_chapter_new.gml - flagship condition logic and backward-compatible save-field handling need verification.

<sub>Shadow auto-approve: would not auto-approve because issues were found.

Re-trigger cubic</sub>

[cubic-dev-ai]

14 issues found across 40 files

Confidence score: 2/5

• High-risk regressions are called out with strong confidence: in scripts/scr_initialize_custom/scr_initialize_custom.gml, v=0 in flagship naming conditions makes the check always false, so ships fail to receive names as intended.
• There are concrete user-facing behavior breaks in core flows, including squad/loadout overwrite behavior in scripts/scr_squads/scr_squads.gml, role ordering regressions in scripts/scr_company_order/scr_company_order.gml, and empty company 11+ cards in scripts/scr_management/scr_management.gml.
• Save compatibility risk is significant in scripts/scr_chapter_new/scr_chapter_new.gml: renaming monastary_name to monastery_name without fallback can drop persisted values for existing saves.
• Pay close attention to scripts/scr_initialize_custom/scr_initialize_custom.gml, scripts/scr_squads/scr_squads.gml, scripts/scr_chapter_new/scr_chapter_new.gml, and scripts/scr_management/scr_management.gml - these contain the highest-impact functional and compatibility regressions to validate before merge.

<sub>Shadow auto-approve: would not auto-approve because issues were found.

Re-trigger cubic</sub>

[cubic-dev-ai]

No issues found across 40 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

<sub>Shadow auto-approve: would require human review. This feature adds new Gloriana ship types, modifies squad generation, equipment, and starting traits across 40 files, which has a broad impact on core game mechanics and requires human review to ensure correctness.

Re-trigger cubic</sub>