style: Apply new gobo rules#1186
Draft
EttyKitty wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 413 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Shadow auto-approve: would auto-approve. All changes are either formatting (blank lines, commas, spacing) enforced by the new gobo config, or the addition of explicit undefined for omitted optional arguments, which is semantically equivalent and safe.
Re-trigger cubic
Contributor
|
This PR is marked as stale, because it has been open for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Apply the new
goboformatting rules across the GML codebase and add.goborc.json. Changes are stylistic for readability and diff quality; a few safe call-site fixes were made to passundefinedfor optional args.Refactors
.goborc.json(4-space indent, vertical arrays/structs, trailing commas, blank lines after blocks, explicitundefinedfor optional args).Bug Fixes
undefinedin helper calls (e.g.,determine_pdf_defence(...),draw_unit_buttons(...)) to prevent runtime issues and clarify intent.Written for commit 43c63a5. Summary will update on new commits. Review in cubic