Skip to content

style: Apply new gobo rules#1186

Draft
EttyKitty wants to merge 4 commits into
mainfrom
style-stuff
Draft

style: Apply new gobo rules#1186
EttyKitty wants to merge 4 commits into
mainfrom
style-stuff

Conversation

@EttyKitty
Copy link
Copy Markdown
Collaborator

@EttyKitty EttyKitty commented May 22, 2026

Summary by cubic

Apply the new gobo formatting rules across the GML codebase and add .goborc.json. Changes are stylistic for readability and diff quality; a few safe call-site fixes were made to pass undefined for optional args.

  • Refactors

    • Added .goborc.json (4-space indent, vertical arrays/structs, trailing commas, blank lines after blocks, explicit undefined for optional args).
    • Ran the formatter across objects/scripts; no behavior changes intended.
  • Bug Fixes

    • Replaced missing/omitted parameters with undefined in helper calls (e.g., determine_pdf_defence(...), draw_unit_buttons(...)) to prevent runtime issues and clarify intent.

Written for commit 43c63a5. Summary will update on new commits. Review in cubic

@github-actions github-actions Bot added Area: JSON Changes to external JSON files or their under-the-hood functionality Size: Warning Type: Code Style Not affecting how code works, only visual changes labels May 22, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 413 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Shadow auto-approve: would auto-approve. All changes are either formatting (blank lines, commas, spacing) enforced by the new gobo config, or the addition of explicit undefined for omitted optional arguments, which is semantically equivalent and safe.

Re-trigger cubic

@EttyKitty EttyKitty marked this pull request as draft May 22, 2026 10:47
@github-actions
Copy link
Copy Markdown
Contributor

This PR is marked as stale, because it has been open for 7 days with no activity.

@github-actions github-actions Bot added the Status: Stale No activity for more than a week label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: JSON Changes to external JSON files or their under-the-hood functionality Size: Warning Status: Stale No activity for more than a week Type: Code Style Not affecting how code works, only visual changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant