feat(contracts): implement guild owner lookup#65
Merged
Lakes41 merged 1 commit intoJun 21, 2026
Conversation
- rebase guild owner lookup onto current main - resolve RPC and contract settings through getChainConfig - support per-call chain and contract overrides - preserve chain-aware config tests with owner lookup coverage
00452c0 to
4647fa2
Compare
Contributor
Author
|
Refreshed this PR at 4647fa2 on top of current main (�fa3297) after the chain-aware contract config landed. What changed in the refresh:
Validation run locally:pm run test:run -- tests/contracts.test.ts tests/client.test.ts -> 26 tests passedpm run typecheck -> passedpm run build -> passed PR status after refresh: mergeable clean. |
Lakes41
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claim #12
Implements
ContractClient.getGuildOwnerso SDK users can fetch guild ownership from the configured contract instead of receivingNOT_IMPLEMENTED.Changes
GuildOwnerParamscontract method input.guildId,rpcUrl, and contract address before making network calls.bytes32and sends aneth_calltogetGuildOwner(bytes32).Testing
npm.cmd run typecheck- passednpm.cmd run test:run- passed, 101 testsnpm.cmd run build- passednpm.cmd run test:smoke- passed ESM/CJS/type smoke checksnpm.cmd run lint- exited 0 with existing repository warnings onlygit diff --check- passedSecurity / compatibility notes
eth_callonly; it does not sign transactions or mutate chain state.