Skip to content

feat(services): add per-request timeout options#64

Open
h1065153539-create wants to merge 1 commit into
Adamantine-guild:mainfrom
h1065153539-create:feat/per-request-timeout
Open

feat(services): add per-request timeout options#64
h1065153539-create wants to merge 1 commit into
Adamantine-guild:mainfrom
h1065153539-create:feat/per-request-timeout

Conversation

@h1065153539-create

Copy link
Copy Markdown

Summary

/claim #10

Adds shared per-request options for service methods so callers can override the client-level timeout on individual calls while keeping existing signatures backwards-compatible.

Changes

  • Adds exported RequestOptions with timeoutMs and per-request retry support.
  • Threads request options through access, membership, roles, and guild service calls.
  • Keeps existing no-options method calls usable without changing request behavior.
  • Updates the SDK guide and API reference with per-request timeout examples.

Testing

  • npm.cmd run typecheck - passed
  • npm.cmd run test:run - passed, 97 tests
  • npm.cmd run build - passed
  • npm.cmd run test:smoke - passed
  • npm.cmd run lint - exited 0 with existing no-explicit-any warnings
  • git diff --check - passed

Security / compatibility notes

  • Per-request timeouts reuse the existing HttpClient abort handling and continue to surface GuildPassErrorCode.TIMEOUT.
  • Existing call signatures remain valid; the new second argument is optional.
  • No secrets, credentials, or sensitive request details are logged or exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant