Chore: refresh deprecated node and IPFS fallbacks#134
Open
adamantmm wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refreshes shared wallet metadata for ADM and DOGE by removing deprecated endpoints and updating alt_ip fallback IPs to keep service discovery resilient without changing the metadata schema.
Changes:
- Removed deprecated ADM node entry (
https://phecda.adm.im) and a deprecated Tor IPFS onion endpoint from ADM metadata. - Updated
alt_ipfallbacks for ADMinfo.adamant.imandipfs4.adm.im. - Updated
alt_ipfallbacks for DOGEdogenode3.adm.im(both node and/apiservice entries).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/general/adamant/info.json | Removes deprecated ADM/Tor IPFS endpoints and refreshes alt_ip fallbacks for info/IPFS services. |
| assets/general/doge/info.json | Updates alt_ip fallback for dogenode3.adm.im in both node and indexer service definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refreshes deprecated node and IPFS fallbacks in shared wallet metadata for ADM and DOGE.
alt_ipfallbacks forinfo.adamant.im,ipfs4.adm.im, anddogenode3.adm.imRelated issue
Closes #133
External links (optional)
None.
Screenshots or videos (optional)
N/A
Breaking changes
No.
How to test
pnpm exec prettier --check assets/general/adamant/info.json assets/general/doge/info.jsongit diff origin/dev...HEADand verify that only deprecated node entries andalt_ipvalues were updated.Notes for reviewers
Please focus on the shared ADM metadata changes, especially the removed deprecated endpoints and the replacement
alt_ipvalues.Checklist