Deprecate JSON hydrate endpoints; move to .deprecated/#131
Merged
AdaWorldAPI merged 3 commits intomainfrom Feb 20, 2026
Merged
Conversation
PR #127 + #128 added POST /api/v1/qualia/hydrate and write-back. These are rolled back because: 1. Internal operations must never serialize to JSON 2. text_to_dn() is hash soup — DN must carry semantic meaning 3. Pipeline was hollow (hardcoded defaults, match i%8 ghost types) 4. Wrong paradigm: HTTP between crates that share one binary The code is preserved in .deprecated/pr127_128_json_hydrate/ for reference. The rewrite will use &BindSpace borrows directly. Removed from server.rs: - POST /api/v1/qualia/hydrate handler (~240 lines) - POST /api/v1/qualia/write-back handler (~100 lines) - text_to_container(), text_to_dn() helpers - DbState.qualia_graph, DbState.self_dims fields - Hydrate-only imports (ContainerGraph, AgentState, etc.) Total: -418 lines from server.rs
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the qualia substrate JSON endpoints (
/api/v1/qualia/hydrateand/api/v1/qualia/write-back) from the active server codebase and archive them in.deprecated/. This enforces the architectural principle that internal operations must never serialize to JSON—they communicate via&BindSpaceborrows, not HTTP.Key Changes
Removed from
src/bin/server.rs(−418 lines):handle_qualia_hydrate()handler (~240 lines)handle_qualia_writeback()handler (~100 lines)text_to_container(),text_to_dn(),serde_json_escape()DbStatefields:qualia_graph: ContainerGraphandself_dims: SelfDimensionsArchived to
.deprecated/pr127_128_json_hydrate/:server_hydrate_block.rs— complete extracted handler code (406 lines)README.md— deprecation rationale and salvage notesAdded
DEPRECATION_CHANGELOG.md:Rationale
The hydrate endpoints violated the one-binary, zero-JSON-on-hot-path architecture:
text_to_dn()is semantically meaningless — DN paths must encode viewpoint/perspective in the tree, not hash collisionsmatch i % 8)&BindSpacein one binaryThe route concept (message → qualia state → preamble) is sound and will be rewritten as
&Container → &Containeroperations, not JSON endpoints.Not Changed
/api/v1/graph/*endpoints — unchangedhttps://claude.ai/code/session_01PJXVVtCXFi2BvJMrM8gmwE