Ada Cooks project - Loraine & Alice#26
Open
a-lmx wants to merge 410 commits into
Open
Conversation
Cookbook show/ar
Ingredient show/ar
View recipe new edit
Installed carrierwave
Recipe destroy
…nto ingredient_form/ar
Ingredient form/ar
Form error updates
Styling/ar
Styling/ar
…he line.ingredient has been deleted.
Bug fix: Will still load recipe show page even if the ingredient records have been deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lorainekv and I practiced TDD for the first ~80% of this project, and have 100 green specs at the time of submission, which we are proud of. Though we don't have complete coverage, we found the tests very helpful for checking if our new changes broke old code, and look forward to getting even better at the testing the custom actions and methods down the road.
We focused during this project on exploring the differences between HABTM and HMT associations, and on thinking about appropriate locations for each piece of code. While we don't claim every bit of logic is in the right place, we worked to use view helpers and models more in this project, and learned a lot in the process.
We really enjoyed making this project, and hope you enjoy reviewing it.
🍨