Skip to content

Wenjie Fang - Calculator - Octos#14

Open
wf1101 wants to merge 1 commit into
Ada-C9:masterfrom
wf1101:master
Open

Wenjie Fang - Calculator - Octos#14
wf1101 wants to merge 1 commit into
Ada-C9:masterfrom
wf1101:master

Conversation

@wf1101

@wf1101 wf1101 commented Feb 7, 2018

Copy link
Copy Markdown

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user input in variables.
How did you determine what operation to perform? 1. check if the operator user input is included in my program. 2. use case when to determine which operator to perform
Do you feel like you used consistent indentation throughout your code? Yes
If you had more time, what would you have added to or changed about the program? I would like to work on the last enhancement dealing with parenthesis.

@tildeee

tildeee commented Feb 12, 2018

Copy link
Copy Markdown

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. x
Readable code with consistent indentation. x

Fantastic calculator! It works and has all the functionality we expect.

I really like the helper methods you made. is_integer? and is_float? are really clever and have really nice names. This helps make your code read really well!

You added a lot of detail to the mod method to validate input. Good job :)

I really like that the program loops, and it asks me if I want to keep practicing/continue practicing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants