Submit Adagrams code#9
Open
geneminde wants to merge 5 commits into
Open
Conversation
iris-lux
pushed a commit
to iris-lux/adagrams
that referenced
this pull request
Sep 18, 2020
rubric: new format, comp qs -> reflection
CheezItMan
reviewed
Sep 21, 2020
Collaborator
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit the learning goals here. Well done.
| @@ -0,0 +1,86 @@ | |||
| require 'csv' | |||
|
|
|||
| def draw_letters() | |||
| return hand | ||
| end | ||
|
|
||
| def uses_available_letters?(input, letters_in_hand) |
| return true | ||
| end | ||
|
|
||
| def score_word(word) |
Collaborator
There was a problem hiding this comment.
👍 I love the use of a hash here.
Comment on lines
+83
to
+86
| def is_in_english_dict?(input) | ||
| dict = CSV.read('assets/dictionary-english.csv') | ||
| dict.include?([input.downcase]) ? true : false | ||
| end No newline at end of file |
Collaborator
There was a problem hiding this comment.
👍 Very compact and readable.
| return score | ||
| end | ||
|
|
||
| def highest_score_from(words) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
Enumerablemixin? If so, where and why was it helpful?