Ayesha and Ren's Adagrams project submission#7
Open
ayaseef wants to merge 1 commit into
Open
Conversation
CheezItMan
reviewed
Sep 21, 2020
Collaborator
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Ayesha & Ren, you hit all the learning goals here including the optional dictionary methods. Well done. Take a look at my comments especially about draw_letters and let me know what questions you have.
Comment on lines
+37
to
+41
| until ten_strings_array.length == 10 | ||
| rand_letter = letters_pool_keys[rand(letters_pool_keys.size)] | ||
| if (letters_pool_to_draw_from[rand_letter]).zero? | ||
| next | ||
| else |
Collaborator
There was a problem hiding this comment.
This runs, but it gives an equal probability of drawing a Z and an E.
A better strategy would be to use your hash to build an array of all the letters with 9 As, 2 Bs etc , shuffle the array and then draw the right number of letters.
Comment on lines
+50
to
+51
| # WAVE 2 | ||
| def uses_available_letters?(input, letters_in_hand) |
| end | ||
|
|
||
| # Wave 3 | ||
| def score_word(word) |
Comment on lines
+92
to
+93
| # Wave 4 | ||
| def highest_score_from(words) |
| end | ||
| end | ||
| end | ||
| max_pair |
Collaborator
There was a problem hiding this comment.
Suggested change
| max_pair | |
| return max_pair |
Comment on lines
+117
to
+118
| # Wave 5 | ||
| def is_in_english_dict?(input) |
Collaborator
There was a problem hiding this comment.
👍 , Nice work with the optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
Enumerablemixin? If so, where and why was it helpful?