Skip to content

Sandy & Madeline#28

Open
crypt0kitty wants to merge 7 commits into
Ada-C14:masterfrom
crypt0kitty:master
Open

Sandy & Madeline#28
crypt0kitty wants to merge 7 commits into
Ada-C14:masterfrom
crypt0kitty:master

Conversation

@crypt0kitty
Copy link
Copy Markdown

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

What are the components that make up a method? Method name, parameters (if any), return type and code block.
What are the advantages of using git when collaboratively working on one code base? You can track the changes and roll back if needed.
What kind of relationship did you and your pair have with the unit tests? We took turns writing methods.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? I don’t think we did.
What was one method you and your pair used to debug code? Repl.it to see what was printing out.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? It can be difficult understanding someone else’s code. We tried to explain it to each other and our thinking behind writing the code and that helped.

@made-line
Copy link
Copy Markdown

What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? It can be difficult understanding someone else’s code. We tried to explain it to each other and our thinking behind writing the code and that helped.

Another thing we discussed at the end of the project is how we could've collaborated more, especially during the parts we found challenging. We felt a little self-conscious about struggling with the challenging parts, so we researched it independently and then collaborated when we felt more confident in our answer.

Copy link
Copy Markdown
Collaborator

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Sandy & Madeline, you hit the learning goals here. Well done.

Comment thread lib/adagrams.rb
Comment on lines +1 to +2
# wave 1
def draw_letters
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Straightforward, and effective

Comment thread lib/adagrams.rb
letters_in_hand = input.split(//)
print letters_in_hand

def uses_available_letters?(input, letters_in_hand)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/adagrams.rb
Comment on lines +11 to +15
puts "Enter in a word: "
input = gets.chomp.to_s

letters_in_hand = input.split(//)
print letters_in_hand
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
puts "Enter in a word: "
input = gets.chomp.to_s
letters_in_hand = input.split(//)
print letters_in_hand

Comment thread lib/adagrams.rb
Comment on lines +35 to +36
# wave 3
def score_word(word)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/adagrams.rb
highest_word = nil

words.each do |word|
score = score_word(word)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
score = score_word(word)
score = score_word(word)

Comment thread lib/adagrams.rb
Comment on lines +66 to +67
# wave 4
def highest_score_from(words)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants