Taylor & Kal's Adagram

[kashenafi]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	Method signature (meaning, method name & parameter(s)). Starts with 'def' and ends with 'end.' The code inside of it should take specified data and manipulate it to return a desired output.
What are the advantages of using git when collaboratively working on one code base?	See the changes the other person made. Keep track of versions.
What kind of relationship did you and your pair have with the unit tests?	We were frustrated because our program actually ran the way that was expected, gave desired output, BUT one method did not receive the "right" (for the test) parameter, so we had to go in and refactor that.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	Yes. We used .empty? (to check an array that should hold any winning words that are 10 letters), .each and .map (to iterate over data structures), .length (to check and reference string sizes), .sort_by (to get the hash with the shortest word to the top/first element to pull), to name a few.
What was one method you and your pair used to debug code?	Used 'puts' a lot. Used Ruby Tutor (www.pythontutor.com).
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	1. We talked about Ask vs Guess culture. We are both individually leaning towards "ask," so that helped when coordinating/co-working. 2. Our original plan of approach was to do a wave a day. We both worked on how to be flexible with that in reality (especially because of the interdependency in some methods).

[dHelmgren]

Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	(only 2)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Quality	Yes?
Elegant/Clever	✅
Logical/Organized	✅

[dHelmgren]

you can do this with a little less effort and a little more legibly by putting all the letters in a hash like so...

hash = { 
'a':9,
'b':2,
'c':2,
#... etc
}

And then pushing the letter into an array the number of times indicated by the hash. That way, if your boss asks you to put in 8 m's instead of whatever is in there now, it's easier to change!

[dHelmgren]

putting a hash here is helpful too, because it lets you change the score value of the letter more reliably!

[dHelmgren]

when you make a file like this that doesn't have driver code, it's good to remove any testing tools before you submit the final product. ;)