Aimee 👾 - Fire 🔥#4
Open
marks214 wants to merge 5 commits into
Open
Conversation
CheezItMan
reviewed
Apr 7, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done Aimee, you hit the essential classes. Nice work.
Comment on lines
+3
to
6
| Time Complexity: O(n^2) - the stack.pop() method invoked has O(n) time complexity and it is used inside a for loop. | ||
| Space Complexity: O(n) - we keep pushing values to the stack for a string of length n. | ||
| */ | ||
| const balanced = (str) => { |
There was a problem hiding this comment.
👍 I'm pretty sure the pop method has O(1) time complexity leading your solution to O(n) time complexity overall.
|
|
||
| enqueue(element) { | ||
| throw new Error("This method has not been implemented!"); | ||
| enqueue(value) { |
| this.tail = (this.tail + 1) % Queue.maxLenth; | ||
| } | ||
|
|
||
| dequeue() { |
There was a problem hiding this comment.
You should also check to see if the head and tail are equal, if so the Queue is empty and you should do something to avoid removing null entries.
|
|
||
| push() { | ||
| throw new Error("This method has not been implemented!"); | ||
| push(value) { |
| this.store.addLast(value); | ||
| } | ||
|
|
||
| pop() { |
| return lastValue; | ||
| } | ||
|
|
||
| isEmpty() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.