Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 75 additions & 26 deletions lib/recursive-methods.rb
Original file line number Diff line number Diff line change
@@ -1,49 +1,98 @@
# Authoring recursive algorithms. Add comments including time and space complexity for each method.

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n is equal to the input value
# Space complexity: O(n) - where n is equal to the input value
def factorial(n)
raise NotImplementedError, "Method not implemented"
if n < 0
raise ArgumentError, "input must be a number greater than or equal to 0."
elsif n == 1 || n == 0
return 1
else
return n * factorial(n - 1)
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n is equal to the length of the input string

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because s[0..-2] will also create a new array, this makes the time complexity also O(n^2)

# not confident on this space complexity
# Space complexity: O(n ^ 2) - where n is equal to the length of the input string ^ 2
def reverse(s)
raise NotImplementedError, "Method not implemented"
if s.length == 0 || s.length == 1
return s
else
return s[-1] + (reverse(s[0..-2]))
end
end

# Time complexity: ?
# Space complexity: ?
def reverse_inplace(s)
raise NotImplementedError, "Method not implemented"
# Time complexity: O(n) - where n is the length of the string / 2
# Space complexity: O(n) - where n is the length of the string / 2
def reverse_inplace(s, i = 0, j = s.length - 1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Outstanding!

if i >= j
return s
else
temp = s[i]
s[i] = s[j]
s[j] = temp

return reverse_inplace(s, i += 1, j -= 1)
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n is equal to the input value
# Space complexity: O(n) - where n is equal to the input value
def bunny(n)
raise NotImplementedError, "Method not implemented"
if n == 0
return n
else
return 2 + bunny(n - 1)
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n equal the length of the string / 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because s[1..-2] creates a new string of length n-2, this is an O(n^2) for both space and time.

# Space complexity: O(n) - where n equals the length of the string / 2 + the length of the string
def nested(s)
raise NotImplementedError, "Method not implemented"
if s == ""
return true
elsif s.length == 1 || s[0] != "(" || s[-1] != ")"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if s.length ==1 then it can't have a matching paren.

return false
else
return nested(s[1..-2])
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n equals the length of the array

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the above O(n^2)

# Space complexity: O(n) - where n equals the length of the array * 2
def search(array, value)
raise NotImplementedError, "Method not implemented"
if array.empty?
return false
elsif array[0] == value
return true
else
return search(array[1..-1], value)
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n equals the length of the string / 2
# Space complexity: O(n) - where n equals the length of the string / 2 + length of the string
def is_palindrome(s)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O(n^2) similar to the above, look at your reverse in place, could you use a similar technique?

raise NotImplementedError, "Method not implemented"
if s == "" || s.length == 1
return true
elsif s[0] != s[-1]
return false
else
return is_palindrome(s[1..-2])
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) - where n equals the number of digits in the smallest input
# Space complexity: O(n) - where n equals the number of digits in the smallest input
def digit_match(n, m)
raise NotImplementedError, "Method not implemented"
end
if (n / 10 == 0) || (m / 10 == 0)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ifs could be simplified a bit. Otherwise very good!

return (n % 10 != m % 10) ? 0 : 1
else
if (n % 10 == m % 10)
return 1 + digit_match(n / 10, m / 10)
else
return digit_match(n / 10, m / 10)
end
end
end
82 changes: 40 additions & 42 deletions specs/recursion_writing_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'minitest/autorun'
require 'minitest/reporters'
require "minitest/autorun"
require "minitest/reporters"
require "minitest/skip_dsl"
require_relative '../lib/recursive-methods'
require_relative "../lib/recursive-methods"

describe "factorial" do
it "will find the factorial of 0" do
Expand All @@ -23,8 +23,7 @@
answer = factorial(num)

# Assert
expect(answer).must_equal 5*4*3*2*1

expect(answer).must_equal 5 * 4 * 3 * 2 * 1
end

it "will raise an ArgumentError if given a number not >= 0" do
Expand All @@ -38,7 +37,7 @@
end
end

xdescribe "reverse" do
describe "reverse" do
it "will reverse 'cat'" do
# Arrange
string = "cat"
Expand Down Expand Up @@ -83,8 +82,7 @@
end
end


xdescribe "reverse_in_place" do
describe "reverse_in_place" do
it "will reverse 'cat'" do
# Arrange
string = "cat"
Expand Down Expand Up @@ -129,7 +127,7 @@
end
end

xdescribe "bunny" do
describe "bunny" do
it "returns 0 for 0 bunnies" do
# Arrange
count = 0
Expand Down Expand Up @@ -164,7 +162,7 @@
end
end

xdescribe "nested" do
describe "nested" do
it "will return true for empystring" do
# Arrange
string = ""
Expand Down Expand Up @@ -210,7 +208,7 @@
end
end

xdescribe "search" do
describe "search" do
it "will return false for empty array" do
# Arrange
item = "a"
Expand All @@ -224,43 +222,43 @@
end

it "will return true when looking for something in the array" do
# Arrange
item = "a"
array = ["b", "c", "a"]
# Arrange
item = "a"
array = ["b", "c", "a"]

# Act
answer = search(array, item)
# Act
answer = search(array, item)

# Assert
expect(answer).must_equal true
# Assert
expect(answer).must_equal true
end

it "will return false when looking for something not in the array" do
# Arrange
item = "x"
array = ["b", "c", "a"]

# Act
answer = search(array, item)

# Assert
expect(answer).must_equal false
end

it "will return true when finding something at the front of the array" do
# Arrange
item = "b"
array = ["b", "c", "a"]
# Act
answer = search(array, item)
# Assert
expect(answer).must_equal true
end
end

it "will return true when finding something at the front of the array" do
# Arrange
item = "b"
array = ["b", "c", "a"]

# Act
answer = search(array, item)

# Assert
expect(answer).must_equal true
end
end

xdescribe "is_palindrome" do
describe "is_palindrome" do
it "will return true for emptystring" do
# Arrange
string = ""
Expand Down Expand Up @@ -295,7 +293,7 @@
end
end

xdescribe "digit_match" do
describe "digit_match" do
it "returns 4 for 1072503891 and 62530841" do
# Arrange
num1 = 1072503891
Expand All @@ -304,8 +302,8 @@
# Act
answer = digit_match(num1, num2)

# Assert
expect(answer).must_equal 4
# Assert
expect(answer).must_equal 4
end

it "returns 0 for nonmatching numbers" do
Expand All @@ -316,8 +314,8 @@
# Act
answer = digit_match(num1, num2)

# Assert
expect(answer).must_equal 0
# Assert
expect(answer).must_equal 0
end

it "returns 3 for 841 and 62530841" do
Expand All @@ -328,7 +326,7 @@
# Act
answer = digit_match(num1, num2)

# Assert
expect(answer).must_equal 3
# Assert
expect(answer).must_equal 3
end
end
end