Check setAPIVersion return in FillDATPluginInfo - #12
Merged
Conversation
setAPIVersion is [[nodiscard]] in SDK v4; discarding its result produced a C4834 warning. Match Derivative's v4 sample idiom and bail out of plugin info setup if the host does not support this build's API version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11. One straggler commit made after that PR was pushed.
setAPIVersionis[[nodiscard]]in the TouchDesigner SDK v4 headers, so discarding its result emitted a C4834 warning during the build. This matches Derivative's own v4 sample idiom and bails out ofFillDATPluginInfoif the host does not support this build's API version.No behavior change for supported hosts; clears the warning.