fix: change identifier in tauri configuration to net.activitywatch.tauri#214
Merged
fix: change identifier in tauri configuration to net.activitywatch.tauri#214
Conversation
`tauri build` was emitting the warning: > Warn The bundle identifier "net.activitywatch.app" set in `"tauri.conf.json" identifier` ends with `.app`. This is not recommended because it conflicts with the application bundle extension on macOS." This adresses that.
Greptile SummaryThis PR renames the Tauri bundle identifier from Confidence Score: 5/5Safe to merge — trivial config fix with no runtime impact on the codebase. Single-line config change that resolves a documented Tauri build warning. The only note is a P2 observation about OS-level side effects of changing the bundle identifier, which is minor given the 0.1.0 version and small user base. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[tauri build] --> B{Bundle Identifier Check}
B -->|Old: net.activitywatch.app| C[⚠️ Warning: ends with .app\nconflicts with macOS bundle extension]
B -->|New: net.activitywatch.tauri| D[✅ No warning\nValid reverse-DNS identifier]
D --> E[macOS .app bundle]
D --> F[Windows installer]
D --> G[Linux package]
Reviews (1): Last reviewed commit: "fix: change identifier in tauri configur..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tauri buildwas emitting the warning:This adresses that.