Skip to content

OTIO import: map ImageSequenceReference clip trims into media frame space #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tedwaine merged 2 commits into from
Sep 15, 2026
+22 −1
Merged

OTIO import: map ImageSequenceReference clip trims into media frame space #324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e53b3
OTIO import: map ImageSequenceReference clip trims into media frame s…
soupkitchenfilms Jul 19, 2026
96a57cc
Merge branch 'develop' into pr/develop-otio-imageseq-trim
tedwaine Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/timeline/src/timeline_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,11 +616,32 @@ void process_item(

auto source_range = ii->source_range();
if (source_range) {
// SKF patch 0007: xstudio clip active ranges are MEDIA-NATIVE
// file frames (a trim of 1123 must re-import as 1123). OTIO
// source_range however is expressed in the media reference's
// available_range space, which TC-anchored conforms base at
// absolute timecode frames (e.g. 1205912), a million frames
// past the file numbering. Re-anchor ImageSequenceReference
// trims to the file numbering:
// trim = start_frame + (source_start - available_start)
// Collapses to verbatim when available_start == start_frame
// (xstudio / NukeStudio exports).
auto start_val = source_range->start_time().value();
if (auto *isr = dynamic_cast<otio::ImageSequenceReference *>(
ii->media_reference())) {
if (auto avail = isr->available_range()) {
start_val = static_cast<double>(isr->start_frame()) +
(start_val -
avail->start_time()
.rescaled_to(source_range->start_time().rate())
.value());
}
}
self->mail(
active_range_atom_v,
FrameRange(
FrameRateDuration(
static_cast<int>(source_range->start_time().value()),
static_cast<int>(start_val),
FrameRate(fps_to_flicks(source_range->start_time().rate()))),
FrameRateDuration(
static_cast<int>(source_range->duration().value()),
Expand Down
Loading