add data/aliases.json#25
Conversation
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
| "license": "Apache-2.0" | ||
| }, | ||
| "data": { | ||
| "camera": { |
There was a problem hiding this comment.
we are not specifying what can be used here? Is expected? I thought point of schema was to play role of contract verification so programming code can expect things where they should be. Do we have code that specifically waits for camera? If so, should camera be mentioned explicitely as valid key here in schema?
There was a problem hiding this comment.
Is it possible to mention it as a valid key, without restricting any other keys? I've never written a schema before.
Currently the entity types are defined as additionalProperties, so any value is allowed.
If mentioning camera would mean switching to patternProperties and allowing only camera in the pattern, I would prefer not to do that. In that case, adding any other entity type would require updating the schema, even though nothing in the data structure actually changes.
Same way as the code expects "R", "G", "B" channels in the camera files, yet the schema doesn't require that.
2 participants
Add the alias mapping file, with all known to me alternative names for the cameras currently present in the database.
Note: there is currently no schema, or versioning available for this file. We may want to add one prior to next release.