Skip to content

Fix MSVC C4163 warning on 32-bit builds - #2801

Closed
haobinnan wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
haobinnan:main
Closed

haobinnan wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
haobinnan:main

Conversation

@haobinnan

Copy link
Copy Markdown

No description provided.

Signed-off-by: binnan_hao <haobinnan@gmail.com>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: haobinnan / name: binnan_hao (337949f)

@cary-ilm

cary-ilm commented Nov 2, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution, but this is in the vendored OpenJPH source, which we don't modify. It looks like this fix or something similar to it was applied upstream in aous72/OpenJPH#276. Now that OpenJPH 0.33.0 is released, we'll update OpenEXR's vendored version to that, which should resolve the problem, assuming that the OpenJPH code is now correct. If it's not, please submit the relevant fix there.

@cary-ilm cary-ilm closed this Nov 2, 2026
@haobinnan

Copy link
Copy Markdown
Author

Thanks for the contribution, but this is in the vendored OpenJPH source, which we don't modify. It looks like this fix or something similar to it was applied upstream in aous72/OpenJPH#276. Now that OpenJPH 0.33.0 is released, we'll update OpenEXR's vendored version to that, which should resolve the problem, assuming that the OpenJPH code is now correct. If it's not, please submit the relevant fix there.

aous72/OpenJPH#419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants