Disable lossy coding of non-visual channels#2507
Conversation
6117610 to
fd6e691
Compare
Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
fd6e691 to
278c9fc
Compare
|
As discussed in the meeting, DWA has a similar approach to deciding which channels need to be lossless (internal_dwa_classifier.h) |
|
Looks like there is a bug deep in OpenJPH: |
Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
|
@cary-ilm What is the procedure if this patch depends on a version of OpenJPH where method signatures have changed? |
|
This PR goes into the lossy-htj2k branch, not main, and that branch will go into the 3.5 release, and we can make 3.5 depend on a modern OpenJPH. It might be cleaner to submit a separate PR that bumps the OpenJPH version, in external as well as in the CI, merge that, then rebase this off of that. |
|
@cary-ilm the OpenJPH maintainer tells me he does not expect a tagged release (which the build system demands) until sometime in the future, so I guess this PR will remain until then. |
OpenJPH is not optimized for lossy coding of non-visual channels, e.g., depth maps.
This PR use heuristics to detect visual channels: visual channels are those whose suffix or full name is "r", "g", "b", "red", "green" or "blue". Even when requested globally by the caller, lossy coding is disabled on non-visual channels.