Omit specular_weight from metal edge tint in OpenPBR#2863
Open
jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Omit specular_weight from metal edge tint in OpenPBR#2863jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
specular_weight from metal edge tint in OpenPBR#2863jstone-lucasfilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist removes `specular_weight` from the computation of metal edge tint in OpenPBR Surface, aligning the behavior of this shading model with a [proposed fix](AcademySoftwareFoundation/OpenPBR#240) for OpenPBR 1.2. As described in the proposed fix, the edge-tint color for the `generalized_schlick_bsdf` should not be multiplied by `specular_weight`, as the whole lobe is multiplied by `specular_weight` as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist removes
specular_weightfrom the computation of metal edge tint in OpenPBR Surface, aligning the behavior of this shading model with a proposed fix for OpenPBR 1.2.As described in the proposed fix, the edge-tint color for the
generalized_schlick_bsdfshould not be multiplied byspecular_weight, as the whole lobe is multiplied byspecular_weightas well.