Upgrade three.js from r152 to r183#2858
Merged
jstone-lucasfilm merged 6 commits intoAcademySoftwareFoundation:mainfrom Apr 10, 2026
Merged
Upgrade three.js from r152 to r183#2858jstone-lucasfilm merged 6 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 6 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist upgrades the three.js dependency in the MaterialX Web Viewer from r152 to r183, adapting to API changes across the intervening releases. A new `hwEmitVersionDirective` option has been added to GenOptions, allowing the Web Viewer to skip the `#version` directive in generated shaders, as three.js now manages this detail on its own.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
kwokcb
reviewed
Apr 9, 2026
Contributor
kwokcb
left a comment
kwokcb
left a comment
There was a problem hiding this comment.
Looks good in general. I think we want to keep explicit versioning for shaders and not add in the new shader gen option.
This changelist removes the proposed hwEmitVersionDirective flag, replacing its usage with a local edit of source files before they are passed along to Three.js.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
ashwinbhat
approved these changes
Apr 10, 2026
Contributor
ashwinbhat
left a comment
ashwinbhat
left a comment
There was a problem hiding this comment.
The change to locally remove version directive to support three.js RawShaderMaterial looks good to me.
kwokcb
approved these changes
Apr 10, 2026
jstone-lucasfilm
merged commit b26de54
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist upgrades the three.js dependency in the MaterialX Web Viewer from r152 to r183, adapting to API changes across the intervening releases.