Skip to content

Suppress C++23 float_denorm_style deprecation warning in numeric_limits<half> #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cary-ilm merged 2 commits into from
Apr 17, 2026
+18 −1
Merged

Suppress C++23 float_denorm_style deprecation warning in numeric_limits<half> #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527ff90
Suppress C++23 float_denorm_style deprecation warning in numeric_limi…
cary-ilm Mar 1, 2026
65b0081
Merge branch 'main' into float_denorm_style-warning
cary-ilm Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/Imath/half.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,24 @@ template <> class numeric_limits<IMATH_INTERNAL_NAMESPACE::half>
static constexpr bool has_infinity = true;
static constexpr bool has_quiet_NaN = true;
static constexpr bool has_signaling_NaN = true;
static constexpr float_denorm_style has_denorm = denorm_present;

// C++23 deprecates std::float_denorm_style and std::denorm_present but does not remove
// them or provide a replacement. std::numeric_limits still requires has_denorm to be of
// that type, so we must use it. Suppress the warning only in C++23 until the standard
// provides an alternative.
#if (defined(__clang__) || defined(__GNUC__)) && (__cplusplus >= 202302L)
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#elif defined(_MSC_VER) && defined(_MSVC_LANG) && (_MSVC_LANG >= 202302L)
# pragma warning(push)
# pragma warning(disable : 4996)
#endif
static constexpr float_denorm_style has_denorm = denorm_present;
#if (defined(__clang__) || defined(__GNUC__)) && (__cplusplus >= 202302L)
# pragma GCC diagnostic pop
#elif defined(_MSC_VER) && defined(_MSVC_LANG) && (_MSVC_LANG >= 202302L)
# pragma warning(pop)
#endif
static constexpr bool has_denorm_loss = false;
static constexpr IMATH_INTERNAL_NAMESPACE::half infinity () IMATH_NOEXCEPT
{
Expand Down
Loading