Fix #28: Add 'yes' to 'Sends Reply' column for Get Display Brightness command#34
Open
Ununp3ntium115 wants to merge 1 commit intoAbleton:mainfrom
Open
Fix #28: Add 'yes' to 'Sends Reply' column for Get Display Brightness command#34Ununp3ntium115 wants to merge 1 commit intoAbleton:mainfrom
Ununp3ntium115 wants to merge 1 commit intoAbleton:mainfrom
Conversation
…ghtness command The command list table incorrectly showed that Get Display Brightness (0x09) does not send a reply. This commit fixes the table to correctly indicate that the command does send a reply, matching the command description.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a documentation error in the command list table where the "Get Display Brightness" command (0x09) was incorrectly marked as not sending a reply. The fix aligns the table entry with the command's actual behavior documented later in the specification.
Changes:
- Corrected the "Sends Reply" column for command 0x09 from empty to "yes"
- Added chapter reference ".2+|<>" for consistency with the table structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Adding the yes is correct, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #28: Possible typo at "2.4.2 Command List"
The command list table incorrectly showed that Get Display Brightness (0x09)
does not send a reply. This commit fixes the table to correctly indicate
that the command does send a reply, matching the command description.
Changes:
Files Changed:
Ready for squash-and-merge.