Update m4l-production-guidelines.md with detailed font info#13
Open
pko-ableton wants to merge 1 commit intomainfrom
Open
Update m4l-production-guidelines.md with detailed font info#13pko-ableton wants to merge 1 commit intomainfrom
pko-ableton wants to merge 1 commit intomainfrom
Conversation
We should mention the correct font size and font style to use for devices.
Collaborator
Author
|
@MattijsKneppers I have added the correct details for font usage in Device Design. Please review and let me know what you think. |
Contributor
MattijsKneppers
left a comment
MattijsKneppers
left a comment
There was a problem hiding this comment.
Thanks for this Priyanka!
So far we have not actually applied this in our built-in devices (let's discuss further separately to make that happen), so it might be best to wait before merging until that has happened and revisit this PR afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should mention the correct font size and font style to use for devices.