Skip to content

⚡ Limit concurrent background image downloads in ContentRepository#35

Merged
Aatricks merged 1 commit intomainfrom
perf-optimize-content-repository-12468815160325834198
Feb 13, 2026
Merged

⚡ Limit concurrent background image downloads in ContentRepository#35
Aatricks merged 1 commit intomainfrom
perf-optimize-content-repository-12468815160325834198

Conversation

@Aatricks
Copy link
Owner

💡 What:

  • Added a Semaphore(5) named DOWNLOAD_SEMAPHORE to ContentRepository.
  • Modified backgroundCacheImages to wrap downloadAndCacheImage calls with DOWNLOAD_SEMAPHORE.withPermit { ... }.
  • Added a new test ContentRepositoryConcurrencyTest.kt to reproduce the high concurrency issue and verify the fix.

🎯 Why:

  • Previously, backgroundCacheImages launched a coroutine for every image in a chapter immediately. For chapters with many images (e.g., Manhwa/Manga), this could trigger hundreds of concurrent network requests, potentially overwhelming the network connection, causing timeouts, or consuming excessive system resources.
  • Limiting concurrency to 5 ensures steady background downloading without blocking the UI or other critical network tasks.

📊 Measured Improvement:

  • Baseline: A reproduction test with 50 images showed a peak of 50 concurrent requests (unbounded).
  • Optimized: The same test with the fix showed a peak of 5 concurrent requests (strictly limited by the semaphore).
  • This confirms the optimization effectively throttles the background workload.

PR created automatically by Jules for task 12468815160325834198 started by @Aatricks

Introduced `DOWNLOAD_SEMAPHORE` (limit 5) to `ContentRepository` to prevent unbounded concurrency during background image caching.
Updated `backgroundCacheImages` to acquire a permit before downloading each image.
Added `ContentRepositoryConcurrencyTest` to verify the concurrency limit is enforced.

Co-authored-by: Aatricks <113598245+Aatricks@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Aatricks Aatricks merged commit 670459c into main Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant