Conversation
Introduced `DOWNLOAD_SEMAPHORE` (limit 5) to `ContentRepository` to prevent unbounded concurrency during background image caching. Updated `backgroundCacheImages` to acquire a permit before downloading each image. Added `ContentRepositoryConcurrencyTest` to verify the concurrency limit is enforced. Co-authored-by: Aatricks <113598245+Aatricks@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Semaphore(5)namedDOWNLOAD_SEMAPHOREtoContentRepository.backgroundCacheImagesto wrapdownloadAndCacheImagecalls withDOWNLOAD_SEMAPHORE.withPermit { ... }.ContentRepositoryConcurrencyTest.ktto reproduce the high concurrency issue and verify the fix.🎯 Why:
backgroundCacheImageslaunched a coroutine for every image in a chapter immediately. For chapters with many images (e.g., Manhwa/Manga), this could trigger hundreds of concurrent network requests, potentially overwhelming the network connection, causing timeouts, or consuming excessive system resources.📊 Measured Improvement:
PR created automatically by Jules for task 12468815160325834198 started by @Aatricks