Close Bash command-resolution mutation boundary - #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execand mutating or ambiguous command-resolution builtinshash,alias,shopt, andenabletime, negation, coprocess, and brace-group execution syntax before nested mutations can be flattenedSecurity boundary
This prevents a later authored command from being published with a false executable identity after
hash, alias, shell-option, or builtin-resolution state changes. Exactcommandandbuiltinwrappers cannot bypass the boundary. Unknown, dynamic, or invalid grammar fails closed.Validation
dotnet build -c Release --no-restore— 0 warnings, 0 errorsdotnet test -c Release --no-build— 2,543 passeddotnet pack -c Release --no-build -o ./bin/nuget— passedslopwatch analyze --no-baseline --fail-on warning— 0 findingspwsh ./scripts/Add-FileHeaders.ps1 -Verify— passedopenspec validate v0-3-structured-shell-analysis --strict— passedgit diff --check— passedAdversarial review
Independent adversarial review: PASS, no blocking findings. The reviewer exercised direct, quoted, escaped, and concatenated target spellings; recursive dispatch wrappers; reordered, clustered, dynamic, and invalid options; separators, pipelines, substitutions, subshells, static
bash -c; and reserved execution forms. Opaque noncanonical shell wrappers remain incomplete and non-reusable by contract.