Bump SBT 1.10.7, Scala 2.12.20/2.13.16/3.3.5, and all build plugins by halotukozak · Pull Request #5 · AVSystem/monix

halotukozak · 2026-02-26T13:53:34Z

Summary

SBT 1.5.2 → 1.10.7
Scala 2.12.15/2.13.8/3.1.2 → 2.12.20/2.13.16/3.3.5
sbt-tpolecat 0.3.1 (io.github.davidgregory084) → 0.5.3 (org.typelevel)
sbt-mima-plugin → 1.1.4, sbt-jmh → 0.4.7, sbt-scalafmt → 2.5.4, sbt-header → 5.10.0, sbt-pgp → 2.3.1, sbt-sonatype → 3.12.2, sbt-git → 2.1.0, sbt-dynver → 5.1.0, sbt-reproducible-builds → 0.32
sbt-assembly intentionally kept at 1.2.0 (2.x breaks JCTools shading)

Compilation fixes

Added -Wconf suppressions for tpolecat 0.5.x value-discard warnings (Scala 2.13)
Removed -Werror for Scala 3 (tpolecat 0.5.x API change)
Fixed CancelablePromise.scala refutable pattern for Scala 3 (@unchecked)
Suppressed other-implicit-type warning for Scala 2.13.16
Tuned test-scope scalacOptions for pre-existing patterns

Known issues (pre-existing, not introduced by this PR)

Scala.js test CatsEffectIssue380Suite hangs — unrelated to dependency changes
MiMa reports TrampolineExecutionContext startLoop signature change — intentional fix from earlier commit on series/3.x-avs, needs exclusion filter

Test plan

sbt exit loads without errors
sbt ++2.12.20 compile passes
sbt ++2.13.16 compile passes
sbt ++3.3.5 compile passes
sbt +test (JVM tests pass; JS hangs on pre-existing issue)
sbt +mimaReportBinaryIssues (needs TrampolineEC exclusion filter)

🤖 Generated with Claude Code

…gEnabled

- Bump kind-projector and silencer versions\n - Silence other-implicit-type warnings in 2.13\n - Revert sbt-assembly to 1.2.0 to keep shading working

- Explicitly state that starting a new stack trace is intentional for performance and thread-safety\n - Add verification tests in TracingSuite

….typelevel 0.5.3 - Replace io.github.davidgregory084 group with org.typelevel in project/plugins.sbt - Update plugin version from 0.3.1 to 0.5.3 - Add explicit import org.typelevel.scalacoptions.ScalacOptions to build.sbt (required by 0.5.x API) - SBT loads without errors after migration

…tion plan - Create 01-01-SUMMARY.md documenting the org.typelevel migration - Update STATE.md with current position (Phase 01, Plan 02 next) and decisions - Update ROADMAP.md plan progress (1/2 summaries for phase 01) - Mark requirement UP-02 complete in REQUIREMENTS.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@unchecked

- Add -Wconf:msg=unused value of type:silent for Scala 2.13 to suppress -Wvalue-discard warnings newly enabled by tpolecat 0.5.x (pre-existing patterns like trySuccess/tryFailure returning Boolean are intentional) - Remove -Werror for Scala 3 (tpolecat 0.5.x uses -Werror, not -Xfatal-warnings; the existing removal of -Xfatal-warnings was insufficient) - Fix CancelablePromise.scala:245: add @unchecked to val x :: xs pattern (Scala 3 requires annotation for refutable patterns used as definitions) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…erns Add Test / scalacOptions --= to remove warnings that tpolecat 0.5.x newly enables for test compilation but which trigger on pre-existing test patterns: - Remove -Wunused:patvars (2.13) / -Ywarn-unused:patvars (2.12): triggers on for-comprehension loop vars (e.g. `for (i <- 0 until 5) yield Future {...}`) - Remove -Xlint:constant (2.13): triggers on intentional overflow tests (e.g. `mc.orderedUpdate(c2, Long.MaxValue + 1)` in OrderedCancelableSuite) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Create 01-02-SUMMARY.md documenting UAT-verified cross-compilation success on Scala 2.12.20, 2.13.16, and 3.3.5 - Update STATE.md: Phase 01 all plans complete; document known issues (CatsEffectIssue380Suite JS hang, MiMa TrampolineExecutionContext) - Update ROADMAP.md: Phase 1 marked complete (2/2 plans done) - Mark requirements UP-01 and UP-02 complete in REQUIREMENTS.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Updates Monix’s build toolchain to newer SBT/Scala patch versions and refreshes sbt plugins, with follow-up compilation/test adjustments to accommodate tpolecat 0.5.x warning defaults and Scala 3 compiler strictness.

Changes:

Bumped SBT to 1.10.7, updated Scala versions in CI, and upgraded build plugins (including tpolecat → 0.5.3 under org.typelevel).
Adjusted scalacOptions / -Wconf suppressions and test-scope compiler options to keep cross-compilation working under the new toolchain.
Applied a Scala 3 refutable-pattern fix (@unchecked) and added/updated tracing tests and documentation notes about fiber stack-trace behavior.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`project/build.properties`	Bumps SBT version to 1.10.7.
`project/plugins.sbt`	Updates sbt plugin versions and adds a dependency scheme override for `geny`.
`build.sbt`	Adds tpolecat-related `-Wconf` suppressions, tunes test-scope scalac options, and disables Scala 3 fatal warnings.
`.github/workflows/build.yml`	Updates Scala versions in the CI matrix.
`.jvmopts`	Removes a legacy JVM option.
`monix-execution/shared/src/main/scala/monix/execution/CancelablePromise.scala`	Scala 3 compatibility tweak for a refutable pattern binding.
`monix-eval/shared/src/main/scala/monix/eval/Task.scala`	Documents stack-trace behavior for `Task.start` / `startAndForget`.
`tracingTests/src/test/scala/tracing/TracingSuite.scala`	Adds tests asserting stack-trace isolation behavior for fibers.
`.planning/**`	Adds planning/roadmap/state docs for the maintenance effort and decisions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tracingTests/src/test/scala/tracing/TracingSuite.scala

build.sbt

project/plugins.sbt

build.sbt

.github/workflows/build.yml

monix-execution/shared/src/main/scala/monix/execution/CancelablePromise.scala

@unchecked

- Bump Scala to 2.13.18/3.3.7, sbt to 1.12.6 - Bump plugins: sbt-scalajs 1.20.2, sbt-scalafmt 2.5.6, kind-projector 0.13.4 - Migrate sbt-doctest to io.github.sbt-doctest 0.12.4 - Use -quickfix:cat=other-implicit-type instead of -Wconf silence - Add -Wnonunit-statement to tpolecat exclusions instead of -Wconf silence - Restore debug scalacOptions section as commented-out - Remove unnecessary -Xfatal-warnings (tpolecat 0.5.x uses -Werror) - Remove unnecessary @unchecked on CancelablePromise pattern match Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T12:33:00Z

project/build.properties

 #

-sbt.version=1.5.2
+sbt.version=1.12.6


project/build.properties sets sbt.version=1.12.6, but the PR title/description and test plan state the target is SBT 1.10.7. Please align the pinned sbt version with the intended bump (or update the PR description/test plan if 1.12.6 is the actual target), since this value drives local builds and CI caching keys.

Copilot · 2026-03-23T12:33:00Z

.github/workflows/build.yml

        # WARN: build.sbt depends on this key path, as scalaVersion and
        # crossScalaVersions is determined from it
-        scala: [ 2.12.15, 2.13.8, 3.1.2 ]
+        scala: [ 2.12.20, 2.13.18, 3.3.7 ]


The Scala versions in the CI matrix were updated to 2.13.18 and 3.3.7, but the PR description says 2.13.16/3.3.5. Since build.sbt derives scalaVersion/crossScalaVersions from this YAML, please make sure the CI matrix versions match the versions claimed in the PR (or update the PR description to reflect the actual versions).

Copilot · 2026-03-23T12:33:01Z

.github/workflows/build.yml

+          - { java: 8, scala: 2.13.18 }
          # TODO: enable this after it works!
-          # - { java: 8, scala: 3.1.2 }
+          # - { java: 8, scala: 3.3.5 }


The commented-out Scala version under unidoc is 3.3.5, but the rest of the workflow matrix uses 3.3.7. Please update the comment to the same Scala 3 version to avoid confusion when re-enabling that job entry.

Suggested change

# - { java: 8, scala: 3.3.5 }

# - { java: 8, scala: 3.3.7 }

Copilot · 2026-03-23T12:33:01Z

project/plugins.sbt

+addSbtPlugin("de.heikoseeberger"         % "sbt-header"              % "5.10.0")
+addSbtPlugin("org.scalameta"             % "sbt-scalafmt"            % "2.5.6")
+addSbtPlugin("io.github.sbt-doctest"     % "sbt-doctest"             % "0.12.4")


sbt-scalafmt is bumped to 2.5.6 here, but the PR description lists 2.5.4. Please either adjust this version to match the stated bump or update the PR description so the documented plugin versions stay accurate.

mikkolaj · 2026-03-23T15:00:52Z

project/plugins.sbt

+addSbtPlugin("org.xerial.sbt"            % "sbt-sonatype"            % "3.12.2")
+addSbtPlugin("com.github.sbt"            % "sbt-pgp"                 % "2.3.1")
+
+libraryDependencySchemes += "com.lihaoyi" %% "geny" % VersionScheme.Always


Can be removed now.

mikkolaj · 2026-03-23T15:07:54Z

build.sbt

+  // Auto-fix implicit type warnings instead of silencing them
+  Compile / scalacOptions ++= {
+    CrossVersion.partialVersion(scalaVersion.value) match {
+      case Some((2, 13)) => Seq("-quickfix:cat=other-implicit-type")


quickfix works like that:

temporarily add the option like you did here (also remember about Test / scalacOptions)

run source and test compilation that will trigger making quickfixes (with Scala 2.13 since that's the version defined here)

verify everything compiles

remove quickfix options

commit changes made by the compiler

mikkolaj

Pls verify if monix-tail/shared/src/test/scala/monix/tail/IterantToReactivePublisherSuite.scala:229 test runs on your setup. It started to fail for me after the ScalaJS bump.

It passes after making a change to monix-tail/shared/src/main/scala/monix/tail/internal/IterantToReactivePublisher.scala:50:

//      if (out == null) throw null
      if (out == null) throw new NullPointerException()

If throw null is problematic in this version of ScalaJS, then probably we should change all such occurrences in the JS / JVM shared code.

halotukozak and others added 25 commits February 24, 2026 14:40

Fix .jvmopts for modern JDKs by removing unsupported CMSClassUnloadin…

aebeaa0

…gEnabled

Bump sbt to 1.10.7

c55330d

Bump sbt-scoverage to 2.3.1 to resolve scala-xml conflict

b7c6bf5

Bump sbt-scalajs to 1.18.2

3e83f14

Bump sbt-unidoc to 0.5.0 (org change to com.github.sbt)

d9a9cbd

Bump sbt-jmh to 0.4.7

65a0106

Bump sbt-mima-plugin to 1.1.4

c1d3daa

Bump sbt-header to 5.10.0

85cb483

Bump sbt-scalafmt to 2.5.4

031d577

Bump sbt-assembly to 2.3.1

807251c

Bump sbt-reproducible-builds to 0.32

9da2412

Bump sbt-dynver to 5.1.0 (org change to com.github.sbt)

b1d55b8

Bump sbt-git to 2.1.0 (org change to com.github.sbt)

0f8710a

Bump sbt-sonatype to 3.12.2

d365e23

Bump sbt-pgp to 2.3.1

911ea97

Add libraryDependencySchemes for geny to resolve meta-build conflict

f395995

Fix geny version conflict using VersionScheme.Always

6aeefdf

Update Scala versions to 2.12.20, 2.13.16, 3.3.5

45d359d

Fix Scala 2.13.16 compatibility and build configuration

0c9251f

- Bump kind-projector and silencer versions\n - Silence other-implicit-type warnings in 2.13\n - Revert sbt-assembly to 1.2.0 to keep shading working

Clarify Task.start/startAndForget stack tracing behavior

cb4aebe

- Explicitly state that starting a new stack trace is intentional for performance and thread-safety\n - Add verification tests in TracingSuite

Copilot AI review requested due to automatic review settings February 26, 2026 13:53

Copilot started reviewing on behalf of halotukozak February 26, 2026 13:54 View session

Remove .planning from git and add to .gitignore

cdb46e3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI reviewed Feb 26, 2026

View reviewed changes

tracingTests/src/test/scala/tracing/TracingSuite.scala Outdated Show resolved Hide resolved

some reverts

0ecf74e

halotukozak self-assigned this Feb 26, 2026

halotukozak requested a review from mikkolaj February 26, 2026 14:01

mikkolaj reviewed Mar 23, 2026

View reviewed changes

halotukozak requested a review from Copilot March 23, 2026 12:29

Copilot started reviewing on behalf of halotukozak March 23, 2026 12:29 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

mikkolaj reviewed Mar 23, 2026

View reviewed changes

mikkolaj reviewed Mar 24, 2026

View reviewed changes

Conversation

halotukozak commented Feb 26, 2026

Summary

Compilation fixes

Known issues (pre-existing, not introduced by this PR)

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

mikkolaj Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

mikkolaj Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

mikkolaj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants