comment out not ending Semaphore test related to cats-effect#380#10
Open
halotukozak wants to merge 1 commit intoseries/3.x-avsfrom
Open
comment out not ending Semaphore test related to cats-effect#380#10halotukozak wants to merge 1 commit intoseries/3.x-avsfrom
halotukozak wants to merge 1 commit intoseries/3.x-avsfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR disables a non-terminating Semaphore regression test in CatsEffectIssue380Suite that’s related to typelevel/cats-effect#380, presumably to prevent the test suite from hanging.
Changes:
- Commented out the Semaphore-related test case in
CatsEffectIssue380Suite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
monix-catnap/jvm/src/test/scala/monix/catnap/CatsEffectIssue380Suite.scala
Show resolved
Hide resolved
mikkolaj
reviewed
Mar 24, 2026
mikkolaj
left a comment
mikkolaj
left a comment
There was a problem hiding this comment.
When is this test problematic? For me it runs fine, both on series/3.x-avs and bump-dependencies branch.
Member
Author
it runs infinitely on CI for some reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.