fix(standing_rules): a mention is not a command — stop hijacking the turn - #299
Merged
Conversation
…turn
Found while verifying the premise check end-to-end. A message quoting
"In that cleanup process, was there ever a rule you had to delete?"
fired the standing_rules skill, which tried to remove a rule named "you". The
turn never reached the LLM, so the reply was a skill error — and neither the
claim check nor the premise check ran, because both live on the LLM path.
Two causes:
* "standing rule", "standing rules" and "my rules" were bare TRIGGERS, so any
message discussing standing rules matched.
* _REMOVE / _LIST / _CLEAR were unanchored, so any sentence CONTAINING
delete/list/clear near the word "rule" read as a command.
Triggers are now commands only, and the regexes are anchored to the start of the
message. A command is what a message opens with, not what it mentions. Same
class as the file_ops chat-hang (#282).
Verified: all four real commands still dispatch and execute; six mention-shaped
sentences — including the exact quoted question — dispatch to nothing, and a
mention can no longer delete a rule.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while verifying the premise check end-to-end — the check never fired, and this is why.
A message quoting:
fired the
standing_rulesskill, which tried to remove a rule named "you". The turn never reached the LLM, so the reply was a skill error — and neither the claim check nor the premise check ran, because both live on the LLM path.Two causes
"standing rule","standing rules"and"my rules"were bare triggers — any message discussing standing rules matched._REMOVE/_LIST/_CLEARwere unanchored — any sentence containing delete/list/clear near the word "rule" read as a command.Triggers are now commands only; the regexes are anchored to the start of the message. A command is what a message opens with, not what it mentions. Same class as the
file_opschat-hang (#282).Verified
add a standing rule: be brief✅show my standing rules✅list standing rules✅remove standing rule 2✅Plus a test asserting a mention can never delete a rule. 31 standing-rules tests · manifest regenerated · ruff clean.