fix: Compatibility with transformers 4.49+ and 5.0+#137
Open
xander1421 wants to merge 1 commit intoASLP-lab:mainfrom
Open
fix: Compatibility with transformers 4.49+ and 5.0+#137xander1421 wants to merge 1 commit intoASLP-lab:mainfrom
xander1421 wants to merge 1 commit intoASLP-lab:mainfrom
Conversation
Two fixes for newer transformers versions:
1. Add explicit num_attention_heads to LlamaConfig
- transformers 4.49+ requires this for correct head_dim calculation
- head_dim = hidden_size // num_attention_heads
- Without this, rotary embeddings have wrong dimensions
2. Fix LlamaDecoderLayer output handling for transformers 5.0+
- In transformers 5.0, LlamaDecoderLayer returns a tensor directly
- Previously returned tuple (hidden_states, ...)
- Using `x, *_ = block(...)` on a tensor iterates over first dimension,
effectively doing x = tensor[0] and losing the batch dimension
- Changed to `x = block(...)` which works for both old and new versions
Tested with:
- Python 3.14
- PyTorch 2.7
- transformers 5.0.0
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix compatibility issues with newer transformers versions (4.49+ and 5.0+)
Problem
DiffRhythm fails with transformers >= 4.49 due to two issues:
Missing num_attention_heads in LlamaConfig (transformers 4.49+)
The rotary embeddings have incorrect dimensions because head_dim is calculated wrong.
LlamaDecoderLayer output format changed (transformers 5.0+)
(hidden_states, present_key_value, ...)The line
x, *_ = block(...)unpacks a tensor by iterating over its first dimension, effectively doingx = tensor[0]and losing the batch dimension.Solution
Add explicit
num_attention_headsto LlamaConfig:Change output handling to work with both formats:
Testing
Tested successfully with:
Generated 95s audio samples without issues.
🤖 Generated with Claude Code