Repository navigation
Feature/tools - #146
Merged
Merged
Feature/tools#146
Conversation
…cripts, and ci - fix the gain knob drag mapping and needle angle for negative dB values - draft the beats-per-bar field like the BPM field so playback polling stops eating keystrokes - roll back the four param selection gestures on pointercancel and live-read snapping inputs at press time instead of stale closures - rAF-coalesce the block resize preview and dedupe fade curvature by pointer Y as well - route track-header vertical zoom through the kernel dead-zone accumulator and keep inline editors anchored under zoom - restore dock compose float geometry, take reverse/channel-mode rollback, and per-file batch import resilience - activate nested submenu items by keyboard, propagate extension message registration to mounted consumers, and re-measure anchored menus when items change while open - give plugin-mode export and silence commands long client budgets and validate system clipboard clip payloads element by element - degrade reversed REAPER takes with unknown media duration instead of panicking, and serialize the UI settings merge under the cross-process file lock - keep the device switch silent until the new-rate snapshot is committed, recover poisoned locks, cap import_audio_bytes before decode, and write undo companion files atomically - make the arm64 AppImage verification pass without dawn, check cargo exit codes in the CLAP build, validate cached downloads, and fail loudly on artifact or config drift - split three cohesive modules out of the two budget-pinned files, drop the dead tolerance fallback and duplicate font button, and run prettier over the frontend and scripts
…backend, scripts, and ci - run prettier over the frontend and repository scripts - restore morph overlays and the live param view on pointercancel - filter gesture and scrollbar end events by pointerId and replay only pending rAF preview frames - use a non-passive wheel listener for beats-per-bar and yield nested menu keyboard navigation while observing anchored menu content size - roll back optimistic take entries, preserve the multi-file import cancellation generation, and report per-file failures - sanitize clipboard envelopes and stored appearance settings, and stop pumping plugin requests after the native bridge is closed - write undo companion files through unique atomic temp paths, resolve AppImage architecture before die() is used, and pin CI ARCH from the cargo target - add regression coverage for pointer lifecycles, rAF replay, and clipboard parsing while keeping oversized files within their budgets
…stures - run Prettier over all frontend and repository scripts - coalesce BPM and beats wheel commits, reject stale frame callbacks, and discard canceled input drafts without duplicate backend updates - sanitize external parameter clipboard numbers, persisted themes, and live appearance preview values before they reach state or CSS variables - report partial multi-file import failures with the localized summary - clear scrollbar drag state on focus loss and restore morph previews on cancel - use collision-free temporary paths for concurrent undo-history saves - add regression coverage for frame scheduling, clipboard parsing, themes, import status reporting, and undo-history concurrency
- TrackList: persist the wheel-zoom accumulator returned by the pure step resolver; sub-threshold touchpad deltas never reached the dead zone before. - QuickSearch: clamp the selected index against a shrinking result set and guard empty-result keyboard navigation / preview. - canvasPointerDown: keep click-seek listeners until the matching pointer ends; an unrelated pointerup no longer silently cancels the seek. - systemClipboard: reject empty clip templates and sanitize external payloads to a whitelist of known fields, dropping injected keys and bad types. - AppThemeProvider: apply persisted appearance preview on mount (after custom theme colors) and hoist the loader so the storage listener stays stable. - ui_settings: fail loudly instead of falling back to defaults when the update closure result is missing, which silently discarded the patch. - audio reducer: validate folder-import summary counts and arrays. - build.yml: fail when tauri.conf.json is missing rather than shipping artifacts named 0.0.0. - Add a static gate rejecting invalid UTF-8 in owned tracked text files.
Prettier was run across all frontend sources (format:check clean). Repair the remaining truncated UTF-8 sequences in Chinese comments so the source tree decodes cleanly; the new UTF-8 gate keeps it that way. Third-party vendored files are intentionally left at their upstream encodings.
…es, and scripts Frontend: correct GL clip-body premultiplied alpha, reuse the instance buffer across frames, stop the idle capture rAF loop, retry failed frame layers, guard NaN geometry/colors, invalidate stale main-canvas backing stores, align the piano-roll draw signature with its actual viewport, harden axis steps, and clean up timers/listeners/tooltip anchors. Waveform renderers now own their vertex buffers and skip draws after unmount. Backend: keep just-inserted PCM cache entries when all older ones are pinned, clamp MIDI tempo conversions, and validate clipboard time-to-frame offsets. Scripts/CI: partition advisory waivers per ID, make version bumping two-phase, enforce Node >= 22.12, reject empty python gate output, fail fast on missing core deps, add timeouts to installer/probe steps, verify GAME weights before early return, and require a freshly built AppImage binary. Also repair trailing whitespace, missing final newlines, and stale comments; run Prettier over all frontend code.
The backlog/overdue escape hatch sat behind the flushHandle early return: once a requestAnimationFrame was parked (main window occluded, WebView2 pauses rAF indefinitely) every later dispatch just queued behind it and pending grew without bound, so the setTimeout fallback written exactly for this case was dead. Track the handle kind, cancel the parked rAF once the queue hits the limit or the flush deadline passes, and pin the behavior with a regression test that parks rAF forever.
Scoping the workspace export to Capture sessions removed the last production consumer of SnapshotPublisher::diagnose, leaving one cfg(test) caller, so the clippy -D warnings gate died on dead_code for the lib target. Pin the helper to test builds with the reason recorded, so the editor integration test keeps its failure diagnostics without shipping unreachable code in release artifacts.
The heaviest parametric scan in the suite (~5760 buildTimelineTicks calls) runs in about 0.8 s alone but exceeds the 5 s default when all 557 test files contend for workers; the worker contention got it misreported as a regression both locally and in CI. Widen its budget to 20 s — CI retry keeps catching real regressions, this only removes the resource-contention noise without loosening any assertion.
- tooltips: prune rich-content registry entries once their element is detached from the DOM (publishers only ever register, so removed tempo-flag rows retained their element and ReactNode for the window lifetime) - import thunks: end the undo group via the quiet helper so a cleanup rejection cannot mask the real import failure (every sibling thunk already did) - browser guards: reset the Alt modifier flag per chord instead of on every keyup, which let the common release order (A then Alt) read a modifier use as a bare tap - sdk: keep *ForTests helpers out of the versioned public contract; in-repo tests already import the internal modules directly - gestures: delete the unread modifier watcher subsystem, including the bootstrap latch that could not survive a StrictMode remount; live event based isModifierActive covers every call site - utils: drop exports with zero consumers (timeSignatureAtSec cluster, hairline geometry counterpart, leading silence helper, committed value hook, capture error localization) and trim the waveform debug module to its wired pool diagnostics so the documented summary can actually start its timer
… dead ruler pipeline Forced labels were spaced by the user's requested spacing whose floor is 24px, while the yield threshold is a fixed 26px: two consecutive forced labels landing 24-25.9px apart slipped past the forced-yields-right branch and the cascade hid the left change-point label, contradicting the generator's own change-points-must-carry-labels invariant. Pin the forced spacing to the yield threshold at the source and lock it with a regression test. Also delete the production-dead code the unified tick source replaced: buildRulerTicks (its window formula and step selection had already drifted) and resolveCanvasViewportOffset. The old pipeline's still-valid contracts - segment realignment labels (5.1 at 7.25s, no stale old-grid ticks) and follow-previous-signature bar continuity - move onto buildTimelineTicks, which reproduces them verbatim.
The workspace audio import read every source file in full and decoded it into f32 planes before any admission check ran: the byte budget was enforced only afterwards, and per-source it never was at all, so a hostile or corrupt .hfslink manifest pointing sources[].file at an arbitrary huge file could exhaust memory before the digest check could reject it. read_audio gains a bounded variant that stats first and refuses oversized files before reading, the declared manifest size is checked against the real file length, and the import loop rejects once the accumulated decoded bytes pass the budget; each is pinned by a test. Project saves called fs::write on the temp file without syncing it before the rename, contradicting the workspace's own atomic-write discipline: a power loss could leave an empty or truncated project file that the .old rollback deliberately does not restore (it only fires when the target is missing). Both save paths now flush the temp file via one shared helper.
…erify probes The vst3-unix test step relied on PIPESTATUS[0] to classify the exit, but GitHub runs undeclared-shell steps with plain bash -e, without pipefail: the run_gates | tee pipeline always reported tee's status, so every real failure on the four Unix legs came out green and the signal-exit replay criterion plus the failure diagnostics steps were dead code. Declare shell: bash so -o pipefail applies. The Unix verify probes called coreutils timeout unconditionally; macOS runners have no such binary, so the probe died with 127 and the bundle was reported as unloadable with an empty log. run_probe now falls back to a python3 process-group watchdog with timeout-compatible exit semantics (124 on expiry, 128+n on signals) - python3 is present on every leg the scripts run on. Also fixed on the way: - build.ps1 honoured -Target App/Plugin/Clap for staging but then ran the byte-compare and makensis unconditionally, so the two documented single-target entry points failed on missing payload; the models / license / installer stages are now gated to All and Installer. - a manual Gates dispatch read workflow_call's scope input, which does not exist on workflow_dispatch, so every job except static was silently skipped; the input is now declared for both triggers. - vst3-unix extracted the frontend artifact into the repo root dist/ (its own output directory) and then rebuilt the frontend on all four legs; it now extracts to frontend/ and passes --skip-frontend like clap.yml. - the rust-test job re-ran fmt and clippy already owned by dedicated jobs; it now passes -Only test. - HIFISHIFTER_SKIP_CARGO_CHECK was set in three workflows but read by nothing; removed.
…enders complete_cached_analysis used to force changed=true whenever any root had an analysis key, then unconditionally set render_requested and refreshed the display. That tail runs on every prepare_apply and every get_timeline_state, so a finished render was immediately queued again: REAPER kept flashing "Rendering" while idle. Gate the tail on a real baseline change via the new note_analysis_baseline_published helper, making the steady state a no-op. publish_timeline_derived also bumped timeline_revision on every call, but Capture's capture_prepare_job calls it at the start of each render. The render itself then looked like a new input revision and VEGAS re-rendered on every playback start. Advance the revision and request a render only when the derived content fingerprint actually changes. Add two regression tests: idempotent derived publish, and unchanged-baseline tail as a complete no-op.
The chip switched to a neutral tone when render_audible_stale was false, so the common background-refresh case rendered grey and ignored the user's custom accent color, unlike the stretch / waveform / import chips. Pin it to accent and add a regression test asserting the --accent-3 / --accent-11 tokens. Also correct the stale-semantics comment in useRenderStatus: stale only decides whether the left chip yields to the right one, it no longer changes the tone.
The three stacked bars were solid in both states, so the icon alone could not tell whether "always show param blocks" was enabled. Build the icon from the setting: fill the bars when active and outline them when inactive. Both variants share one geometry table, so toggling only changes the fill treatment. Add a regression test covering the filled / outlined states.
The 1.1px stroke made the three hollow bars look almost filled at 15px. Use the repo's 0.8px hairline instead, and pin the width in the regression test so the outline cannot drift back to the heavier weight.
…ant CLAP layout The uninstaller now ticks "delete the shared model library" by default: those weights only ever belong to this product, and "I uninstalled it" should not leave 150 MB behind. Caches and logs stay opt-in because they are the only evidence left after a failure. /DeleteModels and /DeleteCache still override both flags for silent and unattended runs. Overwrite installs no longer execute the previous version's uninstall.exe. That binary belongs to the previous build, so its /S is not ours to trust: the Tauri-era uninstaller opens a language dialog from un.onInit, and its "host still holds the plug-in" notice is a MessageBox without /SD that shows up even in silent mode. Users saw exactly that as a second "HiFiShifter Uninstall" window while the new installer was running. The installer now removes the old tree itself (guarded by HiFiShifter.exe / uninstall.exe so a mis-pointed InstallLocation is never wiped), deletes the registered VST3/CLAP artifacts, the uninstall entry and the shortcuts, and refuses to continue while the app is still running. The single reinstall options page remains the only confirmation, and the removal runs in the INSTFILES pre-callback, so cancelling anywhere earlier leaves the old install untouched. The shared model library root is not a constant across releases, so the installer records it as ModelRoot in the uninstall entry and reads it back when uninstalling or upgrading. Deleting models now also purges the root the previous version registered; keeping them merges that root into the current one (rename, robocopy /MOVE across volumes) and drops duplicates, so "keep" really saves the download instead of leaving a copy nothing reads. Common Files\CLAP now holds a single HiFiShifter.clap. CLAP defines a Windows plug-in as one .clap file in that shared directory and says nothing about side-car resources, so the frontend, models.json and SoundTouchDLL move to %ProgramData%\HiFiShifter\plugin-resources — the same root as the model library. Runtime resolution prefers the sibling HiFiShifter-resources, which keeps portable copies and manual installs self-contained, and falls back to the shared directory. The SoundTouch loader gets the matching candidate, otherwise the installed plug-in would silently degrade to Signalsmith, and upgrade / uninstall clean the old sibling folder. The components page is laid out from the real client rect: the tree, the "required space" line, the description title and the description box each get their own row at 14 px, instead of the 10 px rows that clipped "select components" and "required space". Installer strings are regenerated for all five languages, and the gate now covers the new uninstall defaults, both upgrade branches, the legacy model roots and a CLAP directory that must contain nothing but the module.
- delete gates.yml and plugin-gates.yml - add frontend-build.yml for the shared frontend-dist artifact - drop unit tests, testkit, installer gate, and AppImage smoke from CI - skip plugin self-checks in CI while preserving local defaults - update CI docs and AppImage smoke switch
- pass LogPolicy through the Unix spawn_stderr_tee/tee_loop path - make the DirectML creation timeout Windows-only and document CoreML separately - silence unused non-Windows DirectML parameters - remove unnecessary unsafe blocks from the macOS clipboard helpers Fixes the compile failures in GitHub Actions run 43727891835.
CI downloads frontend-dist/ and builds frontend-dist.zip inside the checkout root. Neither path was ignored, so git status --porcelain reported them as untracked and HIFISHIFTER_GIT_DIRTY baked "dirty" into every CI build.
Dependency advisory scanning is no longer part of CI. The local script remains available for manual runs, and docs/ci.md now lists only the build workflows.
The file browser panel stays mounted after its first open. Its persistent role="listbox" made hasOpenPopupSurface() believe a popup was open, so global Space/Enter were always skipped and a focused button handled the keys natively. Type-ahead ownership also treated Space/Enter on panel toolbar buttons as list shortcuts. Ignore persistent type-ahead listboxes and restrict Space/Enter to list/option targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.