Repository navigation
fix: stop the supervisor from crashing when it saves the best lap - #96
Merged
Merged
Conversation
The supervisor looked for the laptimes folder three levels above its executable. That only works with colcon --symlink-install, where the executable resolves to build/arussim. Without it, the executable is in install/arussim/lib/arussim, the CSV path did not exist, and the supervisor threw an uncaught exception after the first lap. No more lap times were published, so the lap counter of the interface stayed at 1. find_laptimes_dir now walks up from the executable until it finds src/ARUSSim/src/arussim/laptimes, so it works with both build layouts. Failing to read or write the best lap file only logs a warning and lap timing goes on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supervisor looked for the laptimes folder three levels above its executable. That only works with colcon --symlink-install, where the executable resolves to build/arussim. Without it, the executable is in install/arussim/lib/arussim, the CSV path did not exist, and the supervisor threw an uncaught exception after the first lap. No more lap times were published, so the lap counter of the interface stayed at 1.
find_laptimes_dir now walks up from the executable until it finds src/ARUSSim/src/arussim/laptimes, so it works with both build layouts. Failing to read or write the best lap file only logs a warning and lap timing goes on.