Skip to content

docs(auth): fix client_id origin — client generates it, not Hub #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(auth): fix client_id origin — client generates it, not Hub #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions auth.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,10 @@ package proto;
// against its current (and previous) pre-shared key and uses the
// recovered identity to set up the tunnel session.
message Auth {
// Stable client identifier. MUST be exactly nine bytes. The HMAC
// (field 3) covers (client_id || timestamp); any other length
// passes the wire and the HMAC verifies cleanly against the same
// non-nine-byte input on both sides, silently breaking the
// identity contract. Both sender and receiver MUST validate the
// length before computing or checking the HMAC. Not a UUID — the
// client generates it once per installation using a CSPRNG and
// persists it across launches.
// Stable client identifier, exactly nine raw UTF-8 bytes; signed
// by the HMAC together with timestamp. Not a UUID — the client
// generates it once per installation using a cryptographically
// secure RNG and persists it across launches.
bytes client_id = 1;

// Minutes since the project epoch (2024-01-01 UTC), used as a
Expand Down