Repository navigation
fix: improve empty states and error messages - #467
Draft
thulasiramegowda wants to merge 4 commits into
Draft
thulasiramegowda wants to merge 4 commits into
thulasiramegowda wants to merge 4 commits into
Conversation
The description paragraph was styled with a hardcoded hex colour (#D4C58A). This muted gold reads poorly against the light-mode background and bypasses the app's CSS variable theming system. Replace with the existing secondary-text token var(--text2), which resolves to #888888 in dark mode and #666666 in light mode, matching every other secondary text element in the codebase.
When explore() catches an unexpected HTTP error (e.g. 503, 422), the raw error code such as HTTP_503 was displayed directly to the user. Non-technical users have no way to interpret these codes or know what action to take. Any error message whose string starts with 'HTTP_' is now replaced with 'Something went wrong. Please check your connection and try again.' Rate-limit and application-level errors continue to show their own specific, actionable messages unchanged.
The h2 title inside EmptyStateCard used fontSize: '3rem' (~48px), which was visually disproportionate within the 620px-wide card. The oversized heading dominated the icon and description, breaking the visual hierarchy of the empty-state design. Reducing to 1.75rem restores a balanced and readable proportion while keeping the title clearly visible as the primary element.
Previously showNoSearchResults was gated on search.trim(), so the empty-state card only appeared when the text search box caused zero results. If the user selected an Activity classification (e.g. Hibernating) or a Language that matched no repositories, the table silently rendered with zero rows and no explanation. Removing the search.trim() guard makes the empty state trigger whenever filtered.length === 0, regardless of which filter caused it. The CTA button now resets all four filters (search, activity, language, organisation) so the user can recover in one click. The description and button label are updated to reflect this.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Link your account with GitcordThanks for opening this PR, @thulasiramegowda! To receive Discord notifications and contributor tracking for this organization:
Once linked, Gitcord can notify you about reviews, merges, and more. — Posted by Gitcord |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
This PR addresses three existing usability issues in OrgExplorer:
3rem, making it unnecessarily large. Reduced it to1.75remfor better readability.Additional Notes:
These changes improve error communication, visual consistency, and the repository browsing experience.
Checklist
I have reviewed the changes and understand the modifications included in this PR. I will ensure that the contribution meets the project's requirements and address any feedback from the maintainers.