Skip to content

[BUG]: PAT popup input lacks label association and visibility button lacks an accessible name #466

Open

Description

@23241a6749

Bug Description

On main at b396d1b7f50a3341d4a5b9ff67211d95c9a5fb95, the PAT popup displays PERSONAL ACCESS TOKEN in a div. It is not associated with the input, and clicking that text does not focus the field. The icon-only visibility button has no accessible name, making its action unclear to assistive technology.

Expected: the visible label names and focuses the input, and the eye button is named Show token / Hide token according to its next action. The close button is already labelled on current main and needs no change here.

Proposed contribution

I'd like to take this as a focused first contribution: a native label with htmlFor/useId and a dynamic aria-label for the eye button, plus the two regression tests. No token validation, storage, network or focus-management changes are proposed.

I searched token, modal, label and accessibility issues on 16 November and checked all 90 open PR file lists. PRs #452, #448, #445 and #442 touch the same component for validation/storage/cache behaviour; their reviewed patches do not implement this label fix. Issue #363 / PR #364 concern other info buttons and the footer. Please let me know if this overlaps any work that hasn't been posted yet, or if you'd prefer me to coordinate with one of those PRs.

Production build passes. Patched suite: 99 passed / 1 failed; unchanged main: 97 passed / 1 failed. Both have the same ResizeObserver is not defined failure in src/App.test.jsx (tracked by #456 / PR #457). No lint script is defined.

AI tools assisted with the investigation, implementation and tests.

Steps to Reproduce

  1. Explore an organisation without a saved PAT.
  2. On Overview, click Connect PAT & Run.
  3. Click PERSONAL ACCESS TOKEN. The input does not receive focus.
  4. Inspect the input and eye button in the accessibility tree: the visible label is not linked to the input, and the eye button has no name.

No real token is needed. This concerns src/components/PATModal.jsx, not the separate Settings form.

Logs and Screenshots

Two local regression tests reproduce the gaps independently: a label lookup/click test and a visibility-button name/keyboard test. Both fail on unchanged main and pass with the proposed patch.

Baseline failures:

Unable to find a label with the text of: /personal access token/i
Unable to find an accessible element with the role "button" and name "Show token"

Environment Details

  • Windows; React 18 / Vite project.
  • Main: b396d1b7f50a3341d4a5b9ff67211d95c9a5fb95.
  • Local Node 24; Vitest and Testing Library.

Impact

Medium - Feature works but has issues

Code of Conduct

  • I have joined the Discord server and will post updates there
  • I have searched existing issues to avoid duplicates

Activity

  1. gitcordapp commented on Nov 16, 2026

    @gitcordapp

    Link your account with Gitcord

    Thanks for opening this issue, @23241a6749!

    To receive Discord notifications and contributor tracking for this organization:

    1. Join Discord: https://discord.gg/hjUhu33uAn
    2. In Discord, run /link 23241a6749
    3. Paste the verification code into your GitHub bio (or a public gist)
    4. Click Verify in Discord (or run /verify-link 23241a6749)

    Once linked, Gitcord can notify you about assignments, mentions, and more.

    — Posted by Gitcord

  2. 23241a6749 commented on Nov 17, 2026

    @23241a6749
    Author

    I noticed #468 now addresses this issue. I opened this report yesterday with the proposed approach and already have a local patch and two regression tests ready, as noted here and in the Discord thread. I'd still like to contribute to the fix, but I'll hold off opening a duplicate PR. Could a maintainer confirm how we should coordinate? Happy to work together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions