Skip to content

Expose workflow control to hosted MCP clients - #25

Open
ANcpLua wants to merge 1 commit into
mainfrom
agent/default-control-scope
Open

Expose workflow control to hosted MCP clients#25
ANcpLua wants to merge 1 commit into
mainfrom
agent/default-control-scope

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • advertise the approval-gated workflow-control tool on the hosted MCP page
  • align protected-resource discovery coverage with the server's supported qyl:read and qyl:control scopes
  • document the Auth0 default third-party permission required for self-registering clients

The baseline resource-server requirement remains qyl:read; control_workflow_run separately enforces qyl:control at the tool boundary. This PR does not change the Auth0 tenant.

Validation

  • server tests: 67/67
  • server smoke suite
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • README.md is excluded by none and included by none
  • server/mcp-home.html is excluded by none and included by none
  • server/src/main.test.ts is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 07d72201-81fa-4e75-8de4-0c7f311d51e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b73c312b30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
Comment on lines +289 to +290
Grant both as the API's default third-party user permissions so dynamically
registered and other self-registering clients receive both scopes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep workflow control out of default DCR permissions

Granting qyl:control as a default permission gives every dynamically registered client mutation authority after authorization. The server only checks that this scope is present before forwarding a steer, interrupt, or resume command; the advertised destructive/approval annotation is client-side metadata that an arbitrary self-registering client can ignore. This removes the explicit client-grant boundary and allows such a client to interrupt any discoverable active run, so retain a deliberate grant for qyl:control or add a server-enforced approval boundary.

Useful? React with 👍 / 👎.

Comment thread README.md
Comment on lines +289 to +290
Grant both as the API's default third-party user permissions so dynamically
registered and other self-registering clients receive both scopes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the warning about public telemetry registration

This instruction still makes qyl:read a default permission while the preceding setup enables Auth0 Dynamic Client Registration, but the commit deletes the only warning that Auth0 DCR is open and therefore lets anyone self-register and read the deployment's telemetry after authorization. Operators following this deployment guide can now expose traces, logs, sessions, and CI evidence without being told to make that decision deliberately or restrict DCR with the tenant ACL, so retain that disclosure and mitigation guidance.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant