deps: Update ancplua-sdk to 2.2.27 - #6
Closed
renovate[bot] wants to merge 1 commit into
Closed
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bb0d4cf02
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="ANcpLua.Roslyn.Utilities.Sources" Version="2.2.26" PrivateAssets="all" /> | ||
| <PackageReference Include="ANcpLua.Roslyn.Utilities.Sources" Version="2.2.27" PrivateAssets="all" /> |
There was a problem hiding this comment.
With this repo's nuget.config clearing sources down to nuget.org, clean restores must resolve this exact version from NuGet. ANcpLua.Roslyn.Utilities.Sources 2.2.27 is not published there (the NuGet profile/GitHub release list still show 2.2.26 as latest), so any fresh dotnet build Qyl.AutoInstrumentation.slnx will fail during restore before the source-generator project can build. Please keep this on a published package version or add the source that actually contains 2.2.27.
Useful? React with 👍 / 👎.
renovate
Bot
force-pushed
the
renovate/ancplua-sdk
branch
from
June 15, 2026 13:28
5bb0d4c to
f897ce5
Compare
ANcpLua
added a commit
that referenced
this pull request
Jul 1, 2026
…trument (CODE RED #1/#2/#10) (#22) An adversarial OTel-compliance + honesty audit rated this code 3/10. This lands the verified subset of the confirmed HIGH/MEDIUM defects. #1 (HIGH, ~0-duration lie): the HttpClient/AspNetCore/gRPC DiagnosticListeners created their span on the framework's *.Stop event via the 2-arg StartActivity (StartTimeUtc=now) and immediately disposed it, so every emitted span had ~0 duration instead of the real operation latency. New internal QylActivitySource.StartAtAmbientStart(name, kind) stamps the span to the ambient framework Activity's real StartTimeUtc (parented to it for trace correlation), with a now-stamped fallback when there is no ambient activity. All three listeners switched to it. #2 (HIGH, dishonest doc): DiagnosticListenerSubscriber claimed it "publishes the same span shapes" — false while durations were fabricated. Doc now states the actual mechanism (reacts on *.Stop, stamps to ambient start for real duration). #10 (MEDIUM, metrics-semconv): dotnet.thread_pool.thread.count was an unitless ObservableGauge<int>; per OTel semconv it is an (Observable)UpDownCounter with UCUM unit {thread}. Switched instrument type + added unit. Verified: core.slnf Release 0/0; verify-webapi-aot-demo passes (fixture unchanged — the attribute shape is identical; note the fixture is duration-insensitive, which is itself tracked as a separate finding). No PublicAPI change (all internal/private). NOT in this commit (separate verified increments): #3 double-count between the listener and interceptor lanes (+ the fixture that masks it), #4/#11 OTLP Events/Links/Status.Message dropped on ingest, #6 url.scheme, #7 http.request.method_original on the interceptor path, #9 Azure span name ignores methodName. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ANcpLua
added a commit
that referenced
this pull request
Jul 1, 2026
…ginal, Azure operation (CODE RED #6/#7/#9) (#25) #6 (url.scheme, Required on HTTP server spans): StartServerActivity now sets url.scheme from context.Request.Scheme (threaded through QylInterceptedAspNetCore). Added to the AOT demo keep-list so the fixture asserts it. #7 (http.request.method_original): the interceptor client + server paths dropped the original method when Normalize collapsed a non-standard verb to _OTHER. New QylHttpMethod.Normalize(method, out original) returns the raw value for non-standard methods; SetRequestMethod emits http.request.method_original. Threaded through StartClientActivity / StartServerActivity and all three callers (HttpClient, HttpWebRequest, AspNetCore). #9 (Azure operation): QylInterceptedAzure.StartActivity received methodName and dropped it (every Azure span named the fixed "Azure SDK"). Now records it on code.function.name so spans are distinguishable (span name stays low-cardinality per Azure semconv). New public consts QylSemanticAttributes.UrlScheme + CodeFunctionName (PublicAPI.Unshipped updated). Verified: core 0/0; verify-webapi-aot-demo (fixture now asserts url.scheme=http on the server span), source-interceptor-consumer, public-api-baseline all pass. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.2.26→2.2.27Release Notes
ANcpLua/ANcpLua.Roslyn.Utilities (ANcpLua.Roslyn.Utilities.Sources)
v2.2.27What's Changed
df4cb1cby @renovate[bot] in #142Full Changelog: ANcpLua/ANcpLua.Roslyn.Utilities@v2.2.26...v2.2.27
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.