Remove obsolete metric ABI import - #39
Closed
ANcpLua wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ANcpLua
marked this pull request as ready for review
July 19, 2026 07:56
ANcpLua
added a commit
that referenced
this pull request
Jul 19, 2026
…ixed Lands the 8.0 convergence (PRs #38/#39 content) plus the fixes from the adversarially verified 30-agent review — as one release state, not a delete-then-restore history: - EF Core + SqlClient listener spans carry the operation's REAL timing (CommandEndEventData StartTime/Duration; SqlClient Before/After OperationId timestamp pairing) instead of inheriting the enclosing request's start time. - AspNetCore listener no longer forces ActivityTraceFlags.Recorded; sampler decisions and upstream traceparent are honored. Root sampling works because Qyl.Sdk registers the Microsoft.AspNetCore and System.Net.Http ActivitySources (options-gated). - HttpClient + gRPC client interceptor lanes restored as call-site owners: header/metadata capture with redaction, signal-ownership deferral for the completion listeners, core-package consumers keep HTTP/gRPC emission. Capture proven again by the environment-options gate and the dual-lane gRPC demo (managed + NativeAOT). - DB dedupe via ConditionalWeakTable in-flight registry — exactly-once without pinning DbCommand graphs on exported activities. - error.type is the fully-qualified exception type on every qyl-authored lane (Azure keeps its first-party source's native value); all demo assertions updated. - Meter truth: MCP metrics + native Npgsql/NServiceBus meters are consumer-registered per the qyl-native contract; CHANGELOG states the ownership plainly. Full local handoff gate green end-to-end (verify-aot-autoinstrumentation-goal). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Remove one unused
GeneratedCodenamespace import fromQylDbClientMetrics.cs.Why this is separate
This is a one-file stacked follow-up to #38. Keeping the cosmetic import cleanup here reduces #38 to CodeRabbit's 100-file review limit without weakening the 8.0 implementation, generated artifacts, documentation, or verification coverage.
Validation
git diff --checkpasses.