Generalize precision 2

.clang-tidy

@@ -2,45 +2,88 @@ Checks: >
     '-*,
      bugprone-*,
        -bugprone-branch-clone,
+       -bugprone-casting-through-void,
        -bugprone-easily-swappable-parameters,
        -bugprone-exception-escape,
        -bugprone-implicit-widening-of-multiplication-result,
+       -bugprone-multi-level-implicit-pointer-conversion,
      clang-analyzer-*,
        -clang-analyzer-optin.mpi.MPI-Checker,
      clang-diagnostic-*,
+       -clang-diagnostic-deprecated-declarations,
      cppcoreguidelines-*,
        -cppcoreguidelines-avoid-c-arrays,
-       -cppcoreguidelines-avoid-goto,
+       -cppcoreguidelines-avoid-do-while,
        -cppcoreguidelines-avoid-magic-numbers,
        -cppcoreguidelines-avoid-non-const-global-variables,
        -cppcoreguidelines-init-variables,
        -cppcoreguidelines-interfaces-global-init,
+       -cppcoreguidelines-macro-to-enum,
        -cppcoreguidelines-macro-usage,
        -cppcoreguidelines-no-malloc,
        -cppcoreguidelines-non-private-member-variables-in-classes,
        -cppcoreguidelines-owning-memory,
        -cppcoreguidelines-pro-*,
+       -cppcoreguidelines-use-enum-class,
+     google-build-explicit-make-pair,
+     google-build-namespaces,
+     misc-*,
+       -misc-const-correctness,
+       -misc-include-cleaner,
+       -misc-non-private-member-variables-in-classes,
+       -misc-no-recursion,
+       -misc-use-internal-linkage,
      modernize-*,
        -modernize-avoid-c-arrays,
        -modernize-macro-to-enum,
        -modernize-return-braced-init-list,
+       -modernize-use-constraints,
+       -modernize-use-designated-initializers,
+       -modernize-use-integer-sign-comparison,
+       -modernize-use-ranges,
+       -modernize-use-starts-ends-with,
+       -modernize-use-std-numbers,
        -modernize-use-trailing-return-type,
-       -modernize-use-using,
      performance-*,
+       -performance-enum-size,
+     portability-*,
+       -portability-avoid-pragma-once,
+       -portability-template-virtual-member-function,
      readability-*,
+       -readability-avoid-nested-conditional-operator,
+       -readability-avoid-unconditional-preprocessor-if,
        -readability-braces-around-statements,
-       -readability-container-data-pointer,
+       -readability-container-contains,
        -readability-else-after-return,
        -readability-function-cognitive-complexity,
        -readability-function-size,
        -readability-identifier-length,
        -readability-implicit-bool-conversion,
        -readability-isolate-declaration,
        -readability-magic-numbers,
+       -readability-math-missing-parentheses,
        -readability-named-parameter,
+       -readability-redundant-casting,
+       -readability-redundant-member-init,
+       -readability-static-accessed-through-instance,
        -readability-simplify-boolean-expr,
+       -readability-use-concise-preprocessor-directives,
+       -readability-use-std-min-max,
      mpi-*
     '
 
 # Files not ending with nolint.H will be filtered in.
 HeaderFilterRegex: '([^n].....|[^o]....|[^l]...|[^i]..|[^n].|[^t])\.H$'
+
+HeaderFileExtensions: ['', "H", 'h', 'hh', 'hpp', 'hxx']
+
+# We will try to modernize this in the future
+# -modernize-use-constraints
+# -modernize-use-designated-initializers
+# -modernize-use-std-numbers
+# -modernize-use-ranges
+# -modernize-use-integer-sign-comparison
+# -modernize-use-starts-ends-with
+# -readability-container-contains
+# -readability-braces-around-statements
+# -google-global-names-in-headers

.github/dependabot.yml

@@ -0,0 +1,9 @@
+# Dependabot configuration
+# ref: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    target-branch: "development"

.github/workflows/cuda.yml

@@ -18,11 +18,11 @@ jobs:
     env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches"}
     steps:
     - name: Checkout AMReX-Hydro
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         path: AMReX-Hydro
     - name: Checkout AMReX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         repository: AMReX-Codes/amrex
         path: amrex
@@ -92,11 +92,11 @@ jobs:
     env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches"}
     steps:
     - name: Checkout AMReX-Hydro
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         path: AMReX-Hydro
     - name: Checkout AMReX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         repository: AMReX-Codes/amrex
         path: amrex

.github/workflows/docs.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           persist-credentials: false
 
@@ -19,9 +19,8 @@ jobs:
           .github/workflows/dependencies/documentation.sh
           echo "Installing python packages for docs..."
 
-          pip install breathe sphinx sphinx_rtd_theme sphinxcontrib.bibtex
-          pip install docutils
-          pip install sphinx-toolbox
+          python3 -m pip install --upgrade pip
+          python3 -m pip install sphinx==5.0.0 sphinx_rtd_theme sphinxcontrib.bibtex docutils sphinx-toolbox
 
       - name: Build Doxygen Docs
         run: |
@@ -38,25 +37,25 @@ jobs:
 
       - name: Deploy
         if: github.event_name == 'push' && github.repository == 'AMReX-Fluids/AMReX-Hydro' && github.ref == 'refs/heads/development'
-        uses: JamesIves/github-pages-deploy-action@3.7.1
+        uses: JamesIves/github-pages-deploy-action@v4.8.0
         with:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ACCESS_TOKEN: ${{ secrets.DEPLOY_DOCS_HYDRO }}
-          REPOSITORY_NAME: AMReX-Fluids/AMReX-Fluids.github.io
-          BRANCH: main # The branch the action should deploy to.
-          FOLDER: Docs/build/html # The folder the action should deploy.
-          TARGET_FOLDER: amrex-hydro/docs_html # The folder the action should deploy to.
-          CLEAN: false # Do not remove existing files from the deploy target.
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          access-token: ${{ secrets.DEPLOY_DOCS_HYDRO }}
+          repository-name: AMReX-Fluids/AMReX-Fluids.github.io
+          branch: main # The branch the action should deploy to.
+          folder: Docs/build/html # The folder the action should deploy.
+          target-folder: amrex-hydro/docs_html # The folder the action should deploy to.
+          clean: false # Do not remove existing files from the deploy target.
 
       - name: Deploy Doxygen
         if: github.event_name == 'push' && github.repository == 'AMReX-Fluids/AMReX-Hydro' && github.ref == 'refs/heads/development'
-        uses: JamesIves/github-pages-deploy-action@3.7.1
+        uses: JamesIves/github-pages-deploy-action@v4.8.0
         with:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ACCESS_TOKEN: ${{ secrets.DEPLOY_DOCS_HYDRO }}
-          REPOSITORY_NAME: AMReX-Fluids/AMReX-Fluids.github.io
-          BRANCH: main # The branch the action should deploy to.
-          FOLDER: Docs/Doxygen/html # The folder the action should deploy.
-          TARGET_FOLDER: amrex-hydro/Doxygen/html # The folder the action should deploy to.
-          CLEAN: false # Do not remove existing files from the deploy target.
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          access-token: ${{ secrets.DEPLOY_DOCS_HYDRO }}
+          repository-name: AMReX-Fluids/AMReX-Fluids.github.io
+          branch: main # The branch the action should deploy to.
+          folder: Docs/Doxygen/html # The folder the action should deploy.
+          target-folder: amrex-hydro/Doxygen/html # The folder the action should deploy to.
+          clean: false # Do not remove existing files from the deploy target.
 

.github/workflows/gcc.yml

@@ -18,11 +18,11 @@ jobs:
     env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wmissing-include-dirs"}
     steps:
     - name: Checkout AMReX-Hydro
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         path: AMReX-Hydro
     - name: Checkout AMReX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         repository: AMReX-Codes/amrex
         path: amrex
@@ -36,7 +36,7 @@ jobs:
     - name: Load Dependencies
       run: |
         AMReX-Hydro/.github/workflows/dependencies/dependencies.sh
-        amrex/.github/workflows/dependencies/dependencies_clang-tidy.sh 14
+        amrex/.github/workflows/dependencies/dependencies_clang-tidy-apt-llvm.sh 21
         amrex/.github/workflows/dependencies/dependencies_ccache.sh
     - name: Build & Install
       run: |
@@ -76,7 +76,7 @@ jobs:
 
         ${{github.workspace}}/amrex/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt --identifier Godunov
         make -j2 -f clang-tidy-ccache-misses.mak \
-            CLANG_TIDY=clang-tidy-14 \
+            CLANG_TIDY=clang-tidy-21 \
             CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/AMReX-Hydro/.clang-tidy --warnings-as-errors=*"
 
         ccache -s
@@ -88,11 +88,11 @@ jobs:
     env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wmissing-include-dirs"}
     steps:
     - name: Checkout AMReX-Hydro
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         path: AMReX-Hydro
     - name: Checkout AMReX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         repository: AMReX-Codes/amrex
         path: amrex
@@ -106,7 +106,7 @@ jobs:
     - name: Load Dependencies
       run: |
         AMReX-Hydro/.github/workflows/dependencies/dependencies.sh
-        amrex/.github/workflows/dependencies/dependencies_clang-tidy.sh 14
+        amrex/.github/workflows/dependencies/dependencies_clang-tidy-apt-llvm.sh 21
         amrex/.github/workflows/dependencies/dependencies_ccache.sh
     - name: Build & Install
       run: |
@@ -148,7 +148,7 @@ jobs:
 
         ${{github.workspace}}/amrex/Tools/C_scripts/mmclt.py --input ${{github.workspace}}/ccache.log.txt --identifier Godunov
         make -j2 -f clang-tidy-ccache-misses.mak \
-            CLANG_TIDY=clang-tidy-14 \
+            CLANG_TIDY=clang-tidy-21 \
             CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/AMReX-Hydro/.clang-tidy --warnings-as-errors=*"
 
         ccache -s

.github/workflows/hip.yml

@@ -22,11 +22,11 @@ jobs:
     env: {CXXFLAGS: "-Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments"}
     steps:
     - name: Checkout AMReX-Hydro
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         path: AMReX-Hydro
     - name: Checkout AMReX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         repository: AMReX-Codes/amrex
         path: amrex

.github/workflows/sycl.yml

@@ -18,11 +18,11 @@ jobs:
     env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-sign-compare -Wno-missing-braces -Wno-unused-variable -Wno-shadow"}
     steps:
     - name: Checkout AMReX-Hydro
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         path: AMReX-Hydro
     - name: Checkout AMReX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
       with:
         repository: AMReX-Codes/amrex
         path: amrex