Repository navigation
Annier.rocmfp4 support - #86
Merged
Merged
Conversation
Port the self-contained ROCmFP4 Codebook10 dequant module into ggml/rocmfp4/ and wire the new GGML_TYPE_Q4_0_ROCMFP4(=100)/_FAST(=101) types through ggml core, the CPU backend, and the HIP dequant path so the Strix qwen35moe GGUF loads and runs correctly on gfx1151 (no native FP4). Matmul falls back to the cuBLAS/hipBLAS dequant path (correct but slow); MMVQ/MMQ deliberately left off. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Add vec_dot_rocmfp4[_fast]_q8_1 device fns (vecdotq.cuh) and wire rocmfp4 into the mmvq type switch (get_vec_dot_q_cuda / get_vdr_mmvq / mul_mat_vec_q_switch_ type), and enable the MMVQ path (incl. MoE mul_mat_id) for rocmfp4. Decode goes from ~11 t/s (cuBLAS-dequant) to ~75 t/s on gfx1151; output is bit-exact vs M1. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Integrated RCOmfp4 support from https://github.com/charlie12345/rocmfp4-llama
Additional information
Requirements