Skip to content

57 parameterize phase count - #61

Merged
sadda merged 6 commits into
mainfrom
57-parameterize-phase-count
Oct 2, 2026
Merged

sadda merged 6 commits into
mainfrom
57-parameterize-phase-count

Conversation

@haitao-ZCU

Copy link
Copy Markdown
Collaborator

with parameterizations of n_phase and phase count, some general methods are summarized:

  • move solution_expressions() to ComputationBase
  • move extract_phase_results() to ComputationBase
  • all tests passed

@sadda

sadda commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

@haitao-ZCU Perfect, two small additions: make phases an attribute of the class so that it is not computed twice and make it work for a higher number of phases (such as 9), there is a small chance that we will need it later.

@haitao-ZCU

Copy link
Copy Markdown
Collaborator Author
  • move phases to init
  • add to 11 phases
  • update test_computation
  • all tests passed

@sadda
sadda merged commit 9decec2 into main Oct 2, 2026
6 checks passed
@haitao-ZCU
haitao-ZCU deleted the 57-parameterize-phase-count branch October 3, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants