Repository navigation
chore: remove the standalone afi-skills catalog surface - #8
Merged
Merged
Conversation
The Gateway authenticates and routes; it does not own or serve a manually curated agent skills catalog. Removes the file-backed reader of the deleted afi-skills repository and everything that existed only to expose it. Removed: - src/services/skillsService.ts (read ../afi-skills/manifest.json; the AFI_SKILLS_MANIFEST_PATH / AFI_SKILL_PLUGIN_MAP env vars lived here). - the /api/v1/skills, /api/v1/skills/:id, /api/v1/skills/capabilities routes and their imports in src/http/app.ts. - tests/skills.test.ts (proved only the removed behavior). - stale afi-skills references in src/index.ts comments and two docs. Added tests/guardrails/no-skills-surface.test.ts to make reintroduction (sibling reader, env var, service module, route surface, CI checkout) structurally impossible. Gateway's real boundary behavior is untouched: authentication, tenant/provider resolution, provider-to-strategy authorization, routing, honest errors, routes-not-writes, and the evidence-v2 boundary. build + typecheck + full test suite (56/56) green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Gateway authenticates and routes; it does not own or serve a manually curated agent skills catalog. This removes the file-backed reader of the deleted
afi-skillsrepository and everything that existed only to expose it.Removed
src/services/skillsService.ts— read../afi-skills/manifest.json; theAFI_SKILLS_MANIFEST_PATHandAFI_SKILL_PLUGIN_MAPenvironment variables lived here./api/v1/skills,/api/v1/skills/:id,/api/v1/skills/capabilitiesand their imports insrc/http/app.ts(all three were backed solely by the removed manifest — no independent functionality).tests/skills.test.ts— proved only the removed behavior.afi-skillsreferences insrc/index.tscomments and two docs.Added
tests/guardrails/no-skills-surface.test.ts— makes reintroduction (sibling reader, env var, service module, route surface, CI checkout) structurally impossible. Modeled on the existingno-cli-frameworkguardrail.Preserved (untouched)
Authentication, tenant/provider resolution, provider-to-strategy authorization, routing, honest error propagation, routes-not-writes, and the evidence-v2 boundary. No route was replaced with Factory capabilities, no tombstone/redirect was added, and the Gateway does not proxy Factory agent operations.
Verification
typecheck✓ ·build✓ ·test:guardrail✓ · full suite 56/56 ✓ (the routing/boundary tests exercise the app, proving it constructs cleanly without the skills service).🤖 Generated with Claude Code