Skip to content

D8: declare indicators projected-but-unread and widen it to match what is produced #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gio2050 merged 2 commits into from
Aug 4, 2026
Merged

D8: declare indicators projected-but-unread and widen it to match what is produced #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
441c1d6
analysts: declare indicators projected-but-unread and widen it to mat…
Gio2050 Aug 4, 2026
927ec3e
analysts: make the indicators JSDoc claim precise about hash relevance
Gio2050 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion analysts/froggy.enrichment_adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,29 @@ export interface FroggyEnrichedView {
emaDistancePct?: number | null;
isInValueSweetSpot?: boolean | null;
brokeEmaWithBody?: boolean | null;
indicators?: Record<string, number | null> | null;
/**
* Raw indicator readings projected from the technical lane
* (rsi / ema_20 / ema_50 / volume_ratio). Context only — NOT read by this
* adapter or any scorer input; wiring one into an axis is a separately
* governed change. Documented here to match its siblings below, which
* already carry this annotation.
*
* Values are `| undefined` because the producing lane payload marks some
* readings optional (e.g. TechnicalLensV1.volumeRatio): the projecting node
* writes the key with an `undefined` value rather than omitting it or
* substituting null.
*
* The type is widened to match that rather than coercing at the producer
* because widening is the only option that provably changes nothing. The
* alternatives do not: canonical JSON drops an `undefined`-valued key but
* retains a `null`-valued one, and omitting the key changes `Object.keys()`.
* This view reaches no live hash preimage today (`enrichmentHash` is taken
* over the raw lane payloads, not this renamed projection), but
* `strategyLocalViewHash` is a declared-but-unproduced pin over exactly this
* view — so a coercion here would become hash-relevant the moment that
* producer is wired up.
*/
indicators?: Record<string, number | null | undefined> | null;
/**
* ATR(14) projected from the technical lane. Context only — NOT read by
* this adapter or any scorer input; wiring it into an axis is a separately
Expand Down
Loading