Fix duplicate vote/withdraw checks, profit claim period tracking, and resource token validation#3642
Merged
jason-aelf merged 4 commits intomasterfrom Apr 17, 2026
Merged
Conversation
eanzhao
reviewed
Apr 17, 2026
Contributor
eanzhao
left a comment
There was a problem hiding this comment.
Overall 修复思路正确,Profit 的 Math.Max 修复 + 对应测试很扎实。几点问题请看内联评论:主要是 Vote 合约四个不同 assert 用同一错误信息不便排查、TakeResourceTokenBack 的校验与 AdvanceResourceToken 不对称,以及 quadratic 分支下的顺序问题。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3642 +/- ##
=======================================
Coverage 90.62% 90.63%
=======================================
Files 680 680
Lines 26298 26310 +12
Branches 2369 2370 +1
=======================================
+ Hits 23833 23845 +12
Misses 2350 2350
Partials 115 115
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.