GenAI plan validation [Aidan 7 & 8]#60
Merged
Merged
Conversation
16 tasks
PR Review GuideCategory: Own domain (genai) Review Rules
Changed domains
|
quarz12
reviewed
Jun 20, 2026
|
|
||
|
|
||
| class Warning(BaseModel): | ||
| type: Literal["WORKLOAD_EXCEEDED", "SCHEDULING_PREFERENCE", "RISKY_COMBINATION"] |
Collaborator
There was a problem hiding this comment.
I prefer using enums over literals but this works too I guess
Collaborator
Author
There was a problem hiding this comment.
also thought about it, but somehow doesnt look as impediment for now and idk if this would be a problem in the future actually
Collaborator
Author
There was a problem hiding this comment.
if it will, fix tbd, but actually should work
quarz12
approved these changes
Jun 20, 2026
kirillinoz
reviewed
Jun 20, 2026
| message: str | ||
|
|
||
|
|
||
| class PlanValidateResponse(BaseModel): |
Collaborator
There was a problem hiding this comment.
defined but never used
kirillinoz
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.