Feature/tutor feedback 1#49
Open
linnewen wants to merge 7 commits into
Open
Conversation
… AI processing to llm-service
- fixed postgres image version to 17.5 - added proper error handling in RoadmapService - added caching - added comments to workflow files, ansible script, GatewayController, compose.azure.yml, llm-service/main.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[accidently created branch from branch genai-service, so llm-related files are included even though not in main yet, merge genai-service branch first, then tutor-feedback-1?]
CI/CD pipeline:
build.ymlhandles image building and pushing to GHCR,deploy-vm.ymltriggers automatically after build completes successfully viaworkflow_runtype=gha). Each service has its own cache scope to prevent cache invalidation across services.closes #44
closes #40
RoadmapService.java:
@Valueplaceholders onuserHostanduserPort: they were copying thellm.service.*keys instead ofuser.service.*RuntimeExceptionwith proper HTTP status exceptions throughout:404when a user is not found503when user-service or LLM service is unreachable404when a roadmap is not foundcloses #45
Roadmap.java / Milestone.java / Task.java:
@Dataon bidirectional relationships:@DatageneratestoString()andhashCode()that traverse the full object graph, causing infinite recursion. Replaced with explicit@Getter,@Setter,@ToString(exclude = ...), and@EqualsAndHashCode(exclude = ...)closes #47
server/compose.yaml:
postgres:latesttopostgres:17.5: avoids unexpected behaviourcloses #38
Code Comments & Documentation:
Added explanatory comments across all files to clarify intent:
build.ymldeploy-vm.ymldeploy-k8s.ymlprovision.ymllint.ymlplaybook.ymlcompose.azure.ymlGatewayController.javamain.py