Skip to content

Task: Fix Spring Service Document API#158

Open
ladu-tu wants to merge 8 commits into
mainfrom
task/fix-spring-document-api
Open

Task: Fix Spring Service Document API#158
ladu-tu wants to merge 8 commits into
mainfrom
task/fix-spring-document-api

Conversation

@ladu-tu

@ladu-tu ladu-tu commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR is related to issues reported by @BjarneHa regarding file uploads failing. This PR splits up bidirectional references in the JPA schema, which previously lead to an error due to unbounded recursion. Additionally this PR includes some improvements for text extraction (remove null bytes which can't be stored by PostgreSQL), user lookup (overwrite oicdSubject if it changed, e.g. because of a different keycloak session) and the GenAI interaction (explicit content type) that were made during debug.

Furthermore, documentation for the spring service was added under services/spring/README.md and additional test cases for the KnowledgeBase related classes have been added.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Docs
  • CI / infra

Definition of Done

  • CI is green
  • If the API changed: api/openapi.yaml is updated and lint passes
  • If a service was added or restructured: docker-compose still comes up cleanly (docker compose up)
  • Tests added or updated for the changed behaviour
  • Docs updated where it matters (README, ADRs, comments)

Notes for the reviewer

@ladu-tu ladu-tu requested review from BjarneHa and DoPri as code owners June 19, 2026 21:37
@BjarneHa BjarneHa added the bug Something isn't working label Jun 19, 2026

@BjarneHa BjarneHa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading documents now works but GET /api/v1/knowledgebase/documents/ still yields a HTTP 500 with {"code":"INTERNAL_ERROR","message":"Internal server error"} after a document has been uploaded.

Comment thread docker-compose.yml
@ladu-tu ladu-tu force-pushed the task/fix-spring-document-api branch from 5bbc99a to eae1fb3 Compare June 20, 2026 13:36
@ladu-tu ladu-tu force-pushed the task/fix-spring-document-api branch from eae1fb3 to 1a7ca2f Compare June 20, 2026 14:31
@ladu-tu ladu-tu requested a review from BjarneHa June 21, 2026 15:30
@ladu-tu ladu-tu added documentation Improvements or additions to documentation java Pull requests that update java code labels Jun 21, 2026

@BjarneHa BjarneHa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants