Skip to content

Feature/dash cohort#20

Open
bwalsh wants to merge 18 commits into
ohsu-trainingfrom
feature/dash-cohort
Open

Feature/dash cohort#20
bwalsh wants to merge 18 commits into
ohsu-trainingfrom
feature/dash-cohort

Conversation

@bwalsh

@bwalsh bwalsh commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

This PR creates a dash based cohort builder

Comment thread dash/models/file.py
@@ -0,0 +1,126 @@

from dotwiz import DotWiz

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is DotWiz?

Comment thread dash/pages/cohorts.py
return filters


@callback(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this @callback( ) syntax supposed to do?

Comment thread dash/pages/profile.py
# data = query_service.query("{ program(first:0) { id name projects { id code } } }")
# logger.error(data)

simplified_authz = {k: ','.join([m['method'] for m in v]) for k, v in get_authz().items()}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindof interesting that authorization information is put into a dataframe. Does this hold more than just auth information

@matthewpeterkort

Copy link
Copy Markdown
Collaborator

So what I can gather/summarize from this PR is that you're harvesting information from the data dictionary through queries and then displaying that information via histograms/other data objects that are being inserted into the DOM with the queried information. Is this vaguely correct?

Comment thread dash/figures/histogram.py
'index': f"{entity}-{k}",
'type': 'query-parameter'
},
options=[

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a style structure?

Comment thread dash/figures/histogram.py
return checklists, dfs, names


def histogram_sliders(histograms):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are histogram sliders?

Comment thread dash/pages/cohorts.py
Input({'type': 'query-parameter', 'index': ALL}, 'value'),
Input({'type': 'query-parameter', 'index': ALL}, 'id')
)
def update_counters(values, ids):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I guess the callback functionality attaches to some sort of external button since it is not directly called anywhere within this commit?

Comment thread dash/pages/cohorts.py Outdated
dbc.Tab(observation_accordian, label="Observations"),
]
),
dash_table.DataTable(id='results'),

@matthewpeterkort matthewpeterkort Nov 12, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this giant return list doing? It looks like Structural HTML, but I'm not sure what purpose it serves.

Base automatically changed from feature/staging to ohsu-training February 1, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants