Separate virtual chunk credentials from repo storage#57
Open
charles-turner-bot wants to merge 2 commits into
Open
Separate virtual chunk credentials from repo storage#57charles-turner-bot wants to merge 2 commits into
charles-turner-bot wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This separates Icechunk repo storage auth from virtual chunk container auth.
Fixes #55.
What changed
_resolve_vcc_credentials()to buildauthorize_virtual_chunk_accessseparately from repo
storage_optionsvirtual_chunk_credentials_optionstoIcechunkCatalogIcechunkCatalog.from_json()and derived child catalogs
virtual_chunk_credentials_optionstoIcechunkStoreBuilderso builds canauthorise virtual chunk access independently from the target Icechunk store
Why
We already had a decent separation for non-secret virtual chunk store config
(endpoint/region/etc.) via the serialised
virtual_chunk_model, but credentialhandling still effectively assumed "whatever the repo store does".
That made cases like these awkward to reason about:
This change keeps the existing sidecar behaviour for non-secret config, while
making credentials an explicit runtime concern.
Testing
pixi run pytest tests/test_utils.py tests/test_core.py tests/test_source_build.py -q